-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a nilnesserr linter idea #4
Comments
Run Got total 1 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329446287 Expand
Report issue: https://github.com/gin-gonic/gin/issues |
Run Got total 17 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329446232 Expand
Report issue: https://github.com/fatedier/frp/issues |
Run Got total 3 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329446804 Expand
Report issue: https://github.com/nektos/act/issues |
Run Got total 6 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329447001 Expand
Report issue: https://github.com/v2ray/v2ray-core/issues |
Run Got total 3 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329447082 Expand
Report issue: https://github.com/jesseduffield/lazygit/issues |
Run Got total 4 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329446684 Expand
Report issue: https://github.com/caddyserver/caddy/issues |
Run Got total 2 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329447467 Expand
Report issue: https://github.com/wagoodman/dive/issues |
Run Got total 1 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329447763 Expand
Report issue: https://github.com/go-gorm/gorm/issues |
Run Got total 2 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329447248 Expand
Report issue: https://github.com/gogs/gogs/issues |
Run Got total 88 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329447375 Expand
Report issue: https://github.com/rclone/rclone/issues |
Run Got total 9 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329447653 Expand
Report issue: https://github.com/cli/cli/issues |
Run Got total 37 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329446617 Expand
Report issue: https://github.com/ethereum/go-ethereum/issues |
Run Got total 268 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329447204 Expand
Report issue: https://github.com/minio/minio/issues |
Run Got total 3 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329447929 Expand
Report issue: https://github.com/jesseduffield/lazydocker/issues |
Run Got total 2 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329446560 Expand
Report issue: https://github.com/prometheus/prometheus/issues |
Run Got total 5 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329447881 Expand
Report issue: https://github.com/pocketbase/pocketbase/issues |
Run Got total 11 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329447833 Expand
Report issue: https://github.com/docker/compose/issues |
Run Got total 9 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329447297 Expand
Report issue: https://github.com/hashicorp/terraform/issues |
Run Got total 7 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329448108 Expand
Report issue: https://github.com/gofiber/fiber/issues |
Run Got total 41 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329448031 Expand
Report issue: https://github.com/beego/beego/issues |
Run Got total 4 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329448323 Expand
Report issue: https://github.com/labstack/echo/issues |
Run Got total 9 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329446925 Expand
Report issue: https://github.com/traefik/traefik/issues |
Run Got total 50 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329447398 Expand
Report issue: https://github.com/go-gitea/gitea/issues |
Run Got total 2 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329448280 Expand
Report issue: https://github.com/zeromicro/go-zero/issues |
Run Got total 16 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329448264 Expand
Report issue: https://github.com/helm/helm/issues |
Run Got total 1 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329448483 Expand
Report issue: https://github.com/go-kit/kit/issues |
Run Got total 18 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329446338 Expand
Report issue: https://github.com/gohugoio/hugo/issues |
Run Got total 6 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329452950 Expand
Report issue: https://github.com/getsops/sops/issues |
Run Got total 2 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12331442060 Expand
Report issue: https://github.com/ergo-services/ergo/issues |
Run Got total 2 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12331441718 Expand
Report issue: https://github.com/vmware/govmomi/issues |
Run Got total 3 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12331441142 Expand
Report issue: https://github.com/absmach/magistrala/issues |
Run Got total 2 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12331446515 Expand
Report issue: https://github.com/unidoc/unipdf/issues |
Run Got total 1 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12331446599 Expand
Report issue: https://github.com/thought-machine/please/issues |
Run Got total 1 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12331443425 Expand
Report issue: https://github.com/activecm/rita/issues |
Run Got total 1 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12331448779 Expand
Report issue: https://github.com/kubernetes-sigs/kwok/issues |
Run Got total 2 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12331447142 Expand
Report issue: https://github.com/kcp-dev/kcp/issues |
Where is the code of nilness? |
holy shit, you made a lint bot and just spammed everyone with linting stuff. gg |
This project, You can see the details at #2. There are six ideas mentioned, but only |
Yes, I use go-linter-runner to test my ideas on public GitHub Go repositories. However, in this issue, the linter implementation isn’t very effective, so the output comments above may not have this bug. You can visit go-linter-runner-example to see how it is used |
the `err` has been checked. so it's value must be nil, so should return `r.err` I have an idea to detect code that returns a non-relevant nilness error bug. I checked the top 1000 GitHub Go repositories and found this, all result listed in alingse/sundrylint#4 Signed-off-by: alingse <[email protected]>
use
nilness
to enhance thenilerr
linterthe common case
Real bugs
deleteError != nil
but return an other nil valueerr
kcp-dev/kcp#3219cerr != nil
but return a nil value errorerr
vmware/govmomi#3653err != nil
but return a nil value errorerrRet
XiaoMi/Gaea#278r.err != nil
but return a nil value errorerr
erigontech/erigon#13120update.Error != nil
but return a nil value errorerr
devspace-sh/devspace#2921bindataRead
function checkclErr !=nil
but return a nil value errorerr
go-bindata/go-bindata#86ws.summaryErr != nil
but return a nil value errorerr
aws/copilot-cli#6000err2 != nil
but return a nil value errorerr
smartcontractkit/chainlink#15698errReadRespBody != nil
but return a nil value errorerr
keploy/keploy#2470qErr != nil
but return a nil value errorerr
errata-ai/vale#935call.Err !=nil
but return a nil value errorerr
gopasspw/gopass#3012err !=nil
but return a nil value errore
GoogleCloudPlatform/terraformer#1961False-Positive
see alingse/nilnesserr#1
The text was updated successfully, but these errors were encountered: