Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a nilnesserr linter idea #4

Closed
alingse opened this issue Dec 14, 2024 · 1,097 comments
Closed

a nilnesserr linter idea #4

alingse opened this issue Dec 14, 2024 · 1,097 comments

Comments

@alingse
Copy link
Owner

alingse commented Dec 14, 2024

use nilness to enhance the nilerr linter

the common case

err := do()
if err != nil {
   return err
}
err2 := do2()
if err2 != nil {
   return err // which is a nil value err, should be `return err2`
}

Real bugs

False-Positive

see alingse/nilnesserr#1

Copy link

Run sundrylint on Repo: https://github.com/gin-gonic/gin

Got total 1 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329446287

Expand
  1. context.go#L670 return a error variable but it's nil

Report issue: https://github.com/gin-gonic/gin/issues

Copy link

Run sundrylint on Repo: https://github.com/fatedier/frp

Got total 17 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329446232

Expand
  1. pkg/util/net/kcp.go#L64 return a error variable but it's nil
  2. pkg/util/net/tls.go#L56 return a error variable but it's nil
  3. pkg/util/limit/reader.go#L50 return a error variable but it's nil
  4. client/proxy/sudp.go#L68 return a error variable but it's nil
  5. client/proxy/udp.go#L70 return a error variable but it's nil
  6. client/visitor/sudp.go#L70 return a error variable but it's nil
  7. pkg/config/legacy/parse.go#L63 return a error variable but it's nil
  8. pkg/config/legacy/value.go#L62 return a error variable but it's nil
  9. pkg/config/legacy/visitor.go#L116 return a error variable but it's nil
  10. pkg/config/legacy/visitor.go#L131 return a error variable but it's nil
  11. pkg/config/legacy/visitor.go#L164 return a error variable but it's nil
  12. pkg/util/vhost/https.go#L36 return a error variable but it's nil
  13. pkg/util/tcpmux/httpconnect.go#L67 return a error variable but it's nil
  14. server/proxy/proxy.go#L172 return a error variable but it's nil
  15. server/proxy/xtcp.go#L86 return a error variable but it's nil
  16. cmd/frps/root.go#L116 return a error variable but it's nil
  17. test/e2e/framework/framework.go#L230 return a error variable but it's nil

Report issue: https://github.com/fatedier/frp/issues

Copy link

Run sundrylint on Repo: https://github.com/nektos/act

Got total 3 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329446804

Expand
  1. pkg/runner/action_cache.go#L171 return a error variable but it's nil
  2. pkg/runner/expression.go#L263 return a error variable but it's nil
  3. pkg/container/docker_cli_test.go#L65 return a error variable but it's nil

Report issue: https://github.com/nektos/act/issues

Copy link

Run sundrylint on Repo: https://github.com/v2ray/v2ray-core

Got total 6 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329447001

Expand
  1. transport/internet/tls/config_other.go#L52 return a error variable but it's nil
  2. transport/internet/xtls/config_other.go#L52 return a error variable but it's nil
  3. proxy/http/client.go#L275 return a error variable but it's nil
  4. transport/internet/websocket/hub.go#L110 return a error variable but it's nil
  5. infra/control/config.go#L83 return a error variable but it's nil
  6. main/confloader/external/external.go#L35 return a error variable but it's nil

Report issue: https://github.com/v2ray/v2ray-core/issues

Copy link

Run sundrylint on Repo: https://github.com/jesseduffield/lazygit

Got total 3 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329447082

Expand
  1. pkg/utils/errors.go#L10 return a error variable but it's nil
  2. pkg/commands/git_commands/commit.go#L206 return a error variable but it's nil
  3. pkg/commands/git_commands/status.go#L32 return a error variable but it's nil

Report issue: https://github.com/jesseduffield/lazygit/issues

Copy link

Run sundrylint on Repo: https://github.com/caddyserver/caddy

Got total 4 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329446684

Expand
  1. modules/caddypki/adminapi.go#L229 return a error variable but it's nil
  2. modules/caddyhttp/fileserver/caddyfile.go#L48 return a error variable but it's nil
  3. modules/caddyhttp/reverseproxy/fastcgi/record.go#L49 return a error variable but it's nil
  4. modules/logging/filewriter.go#L58 return a error variable but it's nil

Report issue: https://github.com/caddyserver/caddy/issues

Copy link

Run sundrylint on Repo: https://github.com/wagoodman/dive

Got total 2 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329447467

Expand
  1. dive/image/podman/resolver.go#L33 return a error variable but it's nil
  2. runtime/ui/view/filetree.go#L56 return a error variable but it's nil

Report issue: https://github.com/wagoodman/dive/issues

Copy link

Run sundrylint on Repo: https://github.com/go-gorm/gorm

Got total 1 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329447763

Expand
  1. statement.go#L497 return a error variable but it's nil

Report issue: https://github.com/go-gorm/gorm/issues

Copy link

Run sundrylint on Repo: https://github.com/gogs/gogs

Got total 2 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329447248

Expand
  1. internal/auth/ldap/config.go#L190 return a error variable but it's nil
  2. internal/database/lfs.go#L75 return a error variable but it's nil

Report issue: https://github.com/gogs/gogs/issues

Copy link

Run sundrylint on Repo: https://github.com/rclone/rclone

Got total 88 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329447375

Expand
  1. fs/newfs.go#L87 return a error variable but it's nil
  2. backend/azureblob/azureblob.go#L2242 return a error variable but it's nil
  3. lib/dircache/dircache.go#L445 return a error variable but it's nil
  4. backend/crypt/cipher.go#L311 return a error variable but it's nil
  5. fs/operations/dedupe.go#L343 return a error variable but it's nil
  6. fs/operations/operations.go#L1086 return a error variable but it's nil
  7. fs/operations/operations.go#L1139 return a error variable but it's nil
  8. backend/cache/storage_persistent.go#L479 return a error variable but it's nil
  9. backend/chunker/chunker.go#L1879 return a error variable but it's nil
  10. backend/drive/drive.go#L4107 return a error variable but it's nil
  11. backend/drive/drive.go#L4543 return a error variable but it's nil
  12. backend/fichier/api.go#L107 return a error variable but it's nil
  13. backend/fichier/api.go#L237 return a error variable but it's nil
  14. backend/fichier/api.go#L326 return a error variable but it's nil
  15. backend/fichier/api.go#L510 return a error variable but it's nil
  16. backend/fichier/api.go#L554 return a error variable but it's nil
  17. backend/fichier/api.go#L586 return a error variable but it's nil
  18. backend/fichier/fichier.go#L145 return a error variable but it's nil
  19. backend/filescom/filescom.go#L245 return a error variable but it's nil
  20. backend/filescom/filescom.go#L296 return a error variable but it's nil
  21. backend/ftp/ftp.go#L669 return a error variable but it's nil
  22. backend/googlecloudstorage/googlecloudstorage.go#L777 return a error variable but it's nil
  23. backend/googlephotos/googlephotos.go#L674 return a error variable but it's nil
  24. backend/hasher/kv.go#L207 return a error variable but it's nil
  25. backend/hasher/object.go#L181 return a error variable but it's nil
  26. backend/hasher/object.go#L236 return a error variable but it's nil
  27. backend/hdfs/object.go#L105 return a error variable but it's nil
  28. backend/iclouddrive/api/drive.go#L45 return a error variable but it's nil
  29. backend/iclouddrive/api/drive.go#L93 return a error variable but it's nil
  30. backend/iclouddrive/api/drive.go#L118 return a error variable but it's nil
  31. backend/iclouddrive/api/drive.go#L144 return a error variable but it's nil
  32. backend/iclouddrive/api/drive.go#L165 return a error variable but it's nil
  33. backend/iclouddrive/api/drive.go#L182 return a error variable but it's nil
  34. backend/iclouddrive/api/drive.go#L207 return a error variable but it's nil
  35. backend/iclouddrive/api/drive.go#L242 return a error variable but it's nil
  36. backend/iclouddrive/api/drive.go#L501 return a error variable but it's nil
  37. backend/iclouddrive/api/drive.go#L530 return a error variable but it's nil
  38. backend/iclouddrive/api/drive.go#L551 return a error variable but it's nil
  39. backend/iclouddrive/api/drive.go#L591 return a error variable but it's nil
  40. backend/iclouddrive/iclouddrive.go#L246 return a error variable but it's nil
  41. backend/imagekit/client/media.go#L179 return a error variable but it's nil
  42. backend/imagekit/client/upload.go#L95 return a error variable but it's nil
  43. backend/internetarchive/internetarchive.go#L923 return a error variable but it's nil
  44. backend/jottacloud/jottacloud.go#L709 return a error variable but it's nil
  45. backend/local/local.go#L1601 return a error variable but it's nil
  46. backend/mega/mega.go#L507 return a error variable but it's nil
  47. backend/onedrive/onedrive.go#L2866 return a error variable but it's nil
  48. backend/onedrive/onedrive.go#L2927 return a error variable but it's nil
  49. backend/oracleobjectstorage/client.go#L78 return a error variable but it's nil
  50. backend/oracleobjectstorage/command.go#L262 return a error variable but it's nil
  51. backend/oracleobjectstorage/multipart.go#L125 return a error variable but it's nil
  52. backend/oracleobjectstorage/object.go#L106 return a error variable but it's nil
  53. backend/oracleobjectstorage/object.go#L241 return a error variable but it's nil
  54. backend/oracleobjectstorage/oracleobjectstorage.go#L107 return a error variable but it's nil
  55. backend/pcloud/pcloud.go#L938 return a error variable but it's nil
  56. backend/pikpak/helper.go#L430 return a error variable but it's nil
  57. backend/pikpak/pikpak.go#L899 return a error variable but it's nil
  58. backend/pikpak/pikpak.go#L1028 return a error variable but it's nil
  59. backend/putio/object.go#L41 return a error variable but it's nil
  60. backend/putio/object.go#L57 return a error variable but it's nil
  61. backend/putio/object.go#L156 return a error variable but it's nil
  62. backend/putio/object.go#L283 return a error variable but it's nil
  63. backend/quatrix/quatrix.go#L327 return a error variable but it's nil
  64. backend/s3/s3.go#L6208 return a error variable but it's nil
  65. backend/s3/s3.go#L6648 return a error variable but it's nil
  66. backend/union/upstream/upstream.go#L385 return a error variable but it's nil
  67. backend/webdav/chunking.go#L172 return a error variable but it's nil
  68. backend/zoho/zoho.go#L315 return a error variable but it's nil
  69. backend/zoho/zoho.go#L334 return a error variable but it's nil
  70. backend/zoho/zoho.go#L760 return a error variable but it's nil
  71. cmd/bisync/deltas.go#L285 return a error variable but it's nil
  72. cmd/bisync/listing.go#L452 return a error variable but it's nil
  73. vfs/vfscache/downloaders/downloaders.go#L372 return a error variable but it's nil
  74. vfs/vfscache/item.go#L491 return a error variable but it's nil
  75. vfs/dir.go#L973 return a error variable but it's nil
  76. vfs/dir.go#L1006 return a error variable but it's nil
  77. cmd/nfsmount/nfsmount.go#L115 return a error variable but it's nil
  78. cmd/serve/dlna/cds.go#L178 return a error variable but it's nil
  79. cmd/serve/dlna/cds.go#L253 return a error variable but it's nil
  80. cmd/serve/http/http.go#L136 return a error variable but it's nil
  81. cmd/serve/s3/server.go#L130 return a error variable but it's nil
  82. cmd/serve/webdav/webdav.go#L281 return a error variable but it's nil
  83. fstest/fstests/fstests.go#L2016 return a error variable but it's nil
  84. vfs/vfstest/os.go#L72 return a error variable but it's nil
  85. vfs/vfstest/os.go#L86 return a error variable but it's nil
  86. vfs/vfstest/os.go#L95 return a error variable but it's nil
  87. backend/cache/cache_internal_test.go#L1112 return a error variable but it's nil
  88. fs/fshttp/http_test.go#L108 return a error variable but it's nil

Report issue: https://github.com/rclone/rclone/issues

Copy link

Run sundrylint on Repo: https://github.com/cli/cli

Got total 9 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329447653

Expand
  1. api/queries_user.go#L34 return a error variable but it's nil
  2. pkg/cmd/extension/manager.go#L739 return a error variable but it's nil
  3. pkg/cmd/attestation/artifact/oci/client.go#L92 return a error variable but it's nil
  4. pkg/cmd/attestation/verify/verify.go#L241 return a error variable but it's nil
  5. pkg/cmd/codespace/codespace_selector.go#L116 return a error variable but it's nil
  6. pkg/cmd/pr/shared/editable.go#L441 return a error variable but it's nil
  7. pkg/cmd/pr/shared/editable.go#L455 return a error variable but it's nil
  8. pkg/cmd/repo/edit/edit.go#L329 return a error variable but it's nil
  9. pkg/cmd/repo/fork/fork.go#L348 return a error variable but it's nil

Report issue: https://github.com/cli/cli/issues

Copy link

Run sundrylint on Repo: https://github.com/ethereum/go-ethereum

Got total 37 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329446617

Expand
  1. rlp/raw.go#L193 return a error variable but it's nil
  2. rpc/client.go#L467 return a error variable but it's nil
  3. rpc/ipc.go#L59 return a error variable but it's nil
  4. accounts/keystore/key.go#L187 return a error variable but it's nil
  5. accounts/keystore/passphrase.go#L276 return a error variable but it's nil
  6. accounts/keystore/passphrase.go#L292 return a error variable but it's nil
  7. accounts/keystore/passphrase.go#L330 return a error variable but it's nil
  8. accounts/keystore/presale.go#L113 return a error variable but it's nil
  9. accounts/keystore/presale.go#L128 return a error variable but it's nil
  10. trie/proof.go#L159 return a error variable but it's nil
  11. core/state/statedb.go#L1300 return a error variable but it's nil
  12. core/vm/contracts.go#L1097 return a error variable but it's nil
  13. core/headerchain.go#L353 return a error variable but it's nil
  14. p2p/discover/v5wire/encoding.go#L358 return a error variable but it's nil
  15. p2p/discover/v5wire/encoding.go#L400 return a error variable but it's nil
  16. p2p/discover/v5wire/encoding.go#L417 return a error variable but it's nil
  17. crypto/ecies/ecies.go#L113 return a error variable but it's nil
  18. crypto/ecies/ecies.go#L211 return a error variable but it's nil
  19. crypto/ecies/ecies.go#L226 return a error variable but it's nil
  20. p2p/rlpx/rlpx.go#L316 return a error variable but it's nil
  21. internal/ethapi/api.go#L77 return a error variable but it's nil
  22. internal/ethapi/api.go#L86 return a error variable but it's nil
  23. internal/ethapi/api.go#L475 return a error variable but it's nil
  24. node/endpoints.go#L49 return a error variable but it's nil
  25. eth/filters/api.go#L364 return a error variable but it's nil
  26. ethclient/ethclient.go#L77 return a error variable but it's nil
  27. ethclient/ethclient.go#L308 return a error variable but it's nil
  28. graphql/graphql.go#L879 return a error variable but it's nil
  29. graphql/graphql.go#L974 return a error variable but it's nil
  30. internal/era/era.go#L248 return a error variable but it's nil
  31. internal/era/era.go#L276 return a error variable but it's nil
  32. signer/rules/rules.go#L167 return a error variable but it's nil
  33. signer/rules/rules.go#L180 return a error variable but it's nil
  34. signer/rules/rules.go#L198 return a error variable but it's nil
  35. cmd/clef/main.go#L529 return a error variable but it's nil
  36. cmd/clef/main.go#L1071 return a error variable but it's nil
  37. core/blockchain_test.go#L2305 return a error variable but it's nil

Report issue: https://github.com/ethereum/go-ethereum/issues

Copy link

Run sundrylint on Repo: https://github.com/minio/minio

Got total 268 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329447204

Expand
  1. internal/bucket/bandwidth/monitor_gen.go#L46 return a error variable but it's nil
  2. internal/bucket/bandwidth/monitor_gen.go#L158 return a error variable but it's nil
  3. internal/bucket/bandwidth/reader.go#L93 return a error variable but it's nil
  4. internal/disk/stat_linux.go#L149 return a error variable but it's nil
  5. internal/http/request-recorder.go#L56 return a error variable but it's nil
  6. internal/http/response-recorder.go#L128 return a error variable but it's nil
  7. internal/store/queuestore.go#L277 return a error variable but it's nil
  8. internal/logger/target/kafka/kafka.go#L181 return a error variable but it's nil
  9. internal/bucket/object/lock/lock.go#L589 return a error variable but it's nil
  10. internal/bucket/replication/datatypes_gen.go#L20 return a error variable but it's nil
  11. internal/bucket/replication/datatypes_gen.go#L30 return a error variable but it's nil
  12. internal/bucket/replication/datatypes_gen.go#L52 return a error variable but it's nil
  13. internal/bucket/replication/datatypes_gen.go#L72 return a error variable but it's nil
  14. internal/bucket/replication/datatypes_gen.go#L82 return a error variable but it's nil
  15. internal/bucket/replication/datatypes_gen.go#L104 return a error variable but it's nil
  16. internal/config/drive/drive.go#L93 return a error variable but it's nil
  17. internal/event/target/elasticsearch.go#L99 return a error variable but it's nil
  18. internal/dsync/lock-args_gen.go#L359 return a error variable but it's nil
  19. internal/dsync/lock-args_gen.go#L438 return a error variable but it's nil
  20. internal/dsync/lock-args_gen.go#L448 return a error variable but it's nil
  21. internal/dsync/lock-args_gen.go#L470 return a error variable but it's nil
  22. internal/grid/msg_gen.go#L20 return a error variable but it's nil
  23. internal/grid/msg_gen.go#L30 return a error variable but it's nil
  24. internal/grid/msg_gen.go#L52 return a error variable but it's nil
  25. internal/grid/msg_gen.go#L72 return a error variable but it's nil
  26. internal/grid/msg_gen.go#L82 return a error variable but it's nil
  27. internal/grid/msg_gen.go#L104 return a error variable but it's nil
  28. internal/grid/msg_gen.go#L124 return a error variable but it's nil
  29. internal/grid/msg_gen.go#L134 return a error variable but it's nil
  30. internal/grid/msg_gen.go#L156 return a error variable but it's nil
  31. internal/grid/msg_gen.go#L261 return a error variable but it's nil
  32. internal/grid/msg_gen.go#L423 return a error variable but it's nil
  33. internal/grid/msg_gen.go#L555 return a error variable but it's nil
  34. internal/grid/msg_gen.go#L600 return a error variable but it's nil
  35. internal/grid/msg_gen.go#L678 return a error variable but it's nil
  36. internal/grid/msg_gen.go#L735 return a error variable but it's nil
  37. internal/grid/msg_gen.go#L838 return a error variable but it's nil
  38. internal/grid/msg_gen.go#L992 return a error variable but it's nil
  39. internal/s3select/sql/record.go#L114 return a error variable but it's nil
  40. internal/s3select/sql/record.go#L137 return a error variable but it's nil
  41. cmd/background-newdisks-heal-ops_gen.go#L545 return a error variable but it's nil
  42. cmd/batch-expire.go#L143 return a error variable but it's nil
  43. cmd/batch-expire_gen.go#L542 return a error variable but it's nil
  44. cmd/batch-expire_gen.go#L602 return a error variable but it's nil
  45. cmd/batch-expire_gen.go#L811 return a error variable but it's nil
  46. cmd/batch-handlers_gen.go#L755 return a error variable but it's nil
  47. cmd/batch-job-common-types_gen.go#L73 return a error variable but it's nil
  48. cmd/batch-job-common-types_gen.go#L201 return a error variable but it's nil
  49. cmd/batch-job-common-types_gen.go#L329 return a error variable but it's nil
  50. cmd/batch-job-common-types_gen.go#L404 return a error variable but it's nil
  51. cmd/batch-job-common-types_gen.go#L414 return a error variable but it's nil
  52. cmd/batch-job-common-types_gen.go#L436 return a error variable but it's nil
  53. cmd/batch-job-common-types_gen.go#L517 return a error variable but it's nil
  54. cmd/batch-replicate_gen.go#L89 return a error variable but it's nil
  55. cmd/batch-replicate_gen.go#L242 return a error variable but it's nil
  56. cmd/batch-replicate_gen.go#L270 return a error variable but it's nil
  57. cmd/batch-replicate_gen.go#L338 return a error variable but it's nil
  58. cmd/batch-replicate_gen.go#L348 return a error variable but it's nil
  59. cmd/batch-replicate_gen.go#L370 return a error variable but it's nil
  60. cmd/batch-replicate_gen.go#L588 return a error variable but it's nil
  61. cmd/batch-replicate_gen.go#L633 return a error variable but it's nil
  62. cmd/batch-replicate_gen.go#L946 return a error variable but it's nil
  63. cmd/batch-replicate_gen.go#L1251 return a error variable but it's nil
  64. cmd/batch-replicate_gen.go#L1299 return a error variable but it's nil
  65. cmd/batch-rotate_gen.go#L93 return a error variable but it's nil
  66. cmd/batch-rotate_gen.go#L250 return a error variable but it's nil
  67. cmd/batch-rotate_gen.go#L278 return a error variable but it's nil
  68. cmd/batch-rotate_gen.go#L508 return a error variable but it's nil
  69. cmd/batch-rotate_gen.go#L555 return a error variable but it's nil
  70. cmd/batch-rotate_gen.go#L843 return a error variable but it's nil
  71. cmd/batch-rotate_gen.go#L1064 return a error variable but it's nil
  72. cmd/batch-rotate_gen.go#L1139 return a error variable but it's nil
  73. cmd/batch-rotate_gen.go#L1149 return a error variable but it's nil
  74. cmd/batch-rotate_gen.go#L1171 return a error variable but it's nil
  75. cmd/bootstrap-peer-server_gen.go#L161 return a error variable but it's nil
  76. cmd/bucket-metadata_gen.go#L441 return a error variable but it's nil
  77. cmd/bucket-quota.go#L100 return a error variable but it's nil
  78. cmd/bucket-replication-metrics_gen.go#L89 return a error variable but it's nil
  79. cmd/bucket-replication-metrics_gen.go#L377 return a error variable but it's nil
  80. cmd/bucket-replication-metrics_gen.go#L592 return a error variable but it's nil
  81. cmd/bucket-replication-metrics_gen.go#L832 return a error variable but it's nil
  82. cmd/bucket-replication-metrics_gen.go#L1032 return a error variable but it's nil
  83. cmd/bucket-replication-metrics_gen.go#L1176 return a error variable but it's nil
  84. cmd/bucket-replication-metrics_gen.go#L1297 return a error variable but it's nil
  85. cmd/bucket-replication-metrics_gen.go#L1448 return a error variable but it's nil
  86. cmd/bucket-replication-utils_gen.go#L142 return a error variable but it's nil
  87. cmd/bucket-replication-utils_gen.go#L424 return a error variable but it's nil
  88. cmd/bucket-replication-utils_gen.go#L647 return a error variable but it's nil
  89. cmd/bucket-replication-utils_gen.go#L757 return a error variable but it's nil
  90. cmd/bucket-replication-utils_gen.go#L1398 return a error variable but it's nil
  91. cmd/bucket-replication-utils_gen.go#L1457 return a error variable but it's nil
  92. cmd/bucket-replication-utils_gen.go#L1467 return a error variable but it's nil
  93. cmd/bucket-replication-utils_gen.go#L1489 return a error variable but it's nil
  94. cmd/bucket-replication-utils_gen.go#L1706 return a error variable but it's nil
  95. cmd/bucket-replication-utils_gen.go#L1931 return a error variable but it's nil
  96. cmd/bucket-replication-utils_gen.go#L2362 return a error variable but it's nil
  97. cmd/bucket-replication-utils_gen.go#L2522 return a error variable but it's nil
  98. cmd/bucket-replication-utils_gen.go#L2532 return a error variable but it's nil
  99. cmd/bucket-replication-utils_gen.go#L2554 return a error variable but it's nil
  100. cmd/bucket-stats_gen.go#L332 return a error variable but it's nil
  101. cmd/bucket-stats_gen.go#L855 return a error variable but it's nil
  102. cmd/bucket-stats_gen.go#L915 return a error variable but it's nil
  103. cmd/bucket-stats_gen.go#L1228 return a error variable but it's nil
  104. cmd/bucket-stats_gen.go#L1268 return a error variable but it's nil
  105. cmd/bucket-stats_gen.go#L1477 return a error variable but it's nil
  106. cmd/bucket-stats_gen.go#L1591 return a error variable but it's nil
  107. cmd/bucket-stats_gen.go#L1601 return a error variable but it's nil
  108. cmd/bucket-stats_gen.go#L1623 return a error variable but it's nil
  109. cmd/bucket-stats_gen.go#L1744 return a error variable but it's nil
  110. cmd/bucket-stats_gen.go#L1778 return a error variable but it's nil
  111. cmd/bucket-stats_gen.go#L1930 return a error variable but it's nil
  112. cmd/bucket-stats_gen.go#L2065 return a error variable but it's nil
  113. cmd/bucket-stats_gen.go#L2079 return a error variable but it's nil
  114. cmd/bucket-stats_gen.go#L2172 return a error variable but it's nil
  115. cmd/bucket-stats_gen.go#L2186 return a error variable but it's nil
  116. cmd/bucket-stats_gen.go#L2315 return a error variable but it's nil
  117. cmd/data-usage-cache.go#L1232 return a error variable but it's nil
  118. cmd/data-usage-cache_gen.go#L686 return a error variable but it's nil
  119. cmd/data-usage-cache_gen.go#L1770 return a error variable but it's nil
  120. cmd/data-usage-cache_gen.go#L1885 return a error variable but it's nil
  121. cmd/data-usage-cache_gen.go#L2138 return a error variable but it's nil
  122. cmd/data-usage-cache_gen.go#L2186 return a error variable but it's nil
  123. cmd/data-usage-cache_gen.go#L2239 return a error variable but it's nil
  124. cmd/data-usage-cache_gen.go#L2287 return a error variable but it's nil
  125. cmd/data-usage-cache_gen.go#L2451 return a error variable but it's nil
  126. cmd/data-usage-cache_gen.go#L2509 return a error variable but it's nil
  127. cmd/data-usage-cache_gen.go#L2572 return a error variable but it's nil
  128. cmd/data-usage-cache_gen.go#L2630 return a error variable but it's nil
  129. cmd/data-usage-cache_gen.go#L2918 return a error variable but it's nil
  130. cmd/data-usage-cache_gen.go#L2928 return a error variable but it's nil
  131. cmd/data-usage-cache_gen.go#L2950 return a error variable but it's nil
  132. cmd/data-usage-cache_gen.go#L3195 return a error variable but it's nil
  133. cmd/endpoint-ellipses.go#L480 return a error variable but it's nil
  134. cmd/erasure-server-pool-decom_gen.go#L337 return a error variable but it's nil
  135. cmd/erasure-server-pool-decom_gen.go#L836 return a error variable but it's nil
  136. cmd/erasure-server-pool-decom_gen.go#L1142 return a error variable but it's nil
  137. cmd/erasure-server-pool-rebalance_gen.go#L20 return a error variable but it's nil
  138. cmd/erasure-server-pool-rebalance_gen.go#L30 return a error variable but it's nil
  139. cmd/erasure-server-pool-rebalance_gen.go#L52 return a error variable but it's nil
  140. cmd/erasure-server-pool-rebalance_gen.go#L72 return a error variable but it's nil
  141. cmd/erasure-server-pool-rebalance_gen.go#L82 return a error variable but it's nil
  142. cmd/erasure-server-pool-rebalance_gen.go#L104 return a error variable but it's nil
  143. cmd/erasure-server-pool-rebalance_gen.go#L197 return a error variable but it's nil
  144. cmd/erasure-server-pool-rebalance_gen.go#L544 return a error variable but it's nil
  145. cmd/erasure-server-pool-rebalance_gen.go#L554 return a error variable but it's nil
  146. cmd/erasure-server-pool-rebalance_gen.go#L576 return a error variable but it's nil
  147. cmd/erasure-server-pool-rebalance_gen.go#L622 return a error variable but it's nil
  148. cmd/erasure-server-pool-rebalance_gen.go#L918 return a error variable but it's nil
  149. cmd/erasure-server-pool-rebalance_gen.go#L968 return a error variable but it's nil
  150. cmd/erasure-server-pool.go#L1422 return a error variable but it's nil
  151. cmd/iam.go#L2032 return a error variable but it's nil
  152. cmd/iam.go#L2128 return a error variable but it's nil
  153. cmd/last-minute_gen.go#L89 return a error variable but it's nil
  154. cmd/last-minute_gen.go#L607 return a error variable but it's nil
  155. cmd/local-locker_gen.go#L346 return a error variable but it's nil
  156. cmd/local-locker_gen.go#L553 return a error variable but it's nil
  157. cmd/metacache-set_gen.go#L345 return a error variable but it's nil
  158. cmd/metacache-walk_gen.go#L169 return a error variable but it's nil
  159. cmd/metacache_gen.go#L253 return a error variable but it's nil
  160. cmd/metacache_gen.go#L431 return a error variable but it's nil
  161. cmd/metacache_gen.go#L441 return a error variable but it's nil
  162. cmd/metacache_gen.go#L463 return a error variable but it's nil
  163. cmd/metrics-v2_gen.go#L132 return a error variable but it's nil
  164. cmd/metrics-v2_gen.go#L160 return a error variable but it's nil
  165. cmd/metrics-v2_gen.go#L188 return a error variable but it's nil
  166. cmd/metrics-v2_gen.go#L216 return a error variable but it's nil
  167. cmd/metrics-v2_gen.go#L263 return a error variable but it's nil
  168. cmd/metrics-v2_gen.go#L595 return a error variable but it's nil
  169. cmd/mrf_gen.go#L169 return a error variable but it's nil
  170. cmd/net.go#L128 return a error variable but it's nil
  171. cmd/object-api-datatypes_gen.go#L29 return a error variable but it's nil
  172. cmd/object-api-datatypes_gen.go#L1470 return a error variable but it's nil
  173. cmd/object-api-interface_gen.go#L330 return a error variable but it's nil
  174. cmd/object-api-options.go#L59 return a error variable but it's nil
  175. cmd/object-api-options.go#L73 return a error variable but it's nil
  176. cmd/object-api-options.go#L252 return a error variable but it's nil
  177. cmd/site-replication-metrics_gen.go#L73 return a error variable but it's nil
  178. cmd/site-replication-metrics_gen.go#L351 return a error variable but it's nil
  179. cmd/site-replication-metrics_gen.go#L649 return a error variable but it's nil
  180. cmd/site-replication-metrics_gen.go#L691 return a error variable but it's nil
  181. cmd/site-replication-metrics_gen.go#L964 return a error variable but it's nil
  182. cmd/site-replication-metrics_gen.go#L1588 return a error variable but it's nil
  183. cmd/site-replication-utils_gen.go#L173 return a error variable but it's nil
  184. cmd/site-replication-utils_gen.go#L214 return a error variable but it's nil
  185. cmd/site-replication.go#L763 return a error variable but it's nil
  186. cmd/site-replication.go#L2782 return a error variable but it's nil
  187. cmd/storage-datatypes_gen.go#L46 return a error variable but it's nil
  188. cmd/storage-datatypes_gen.go#L190 return a error variable but it's nil
  189. cmd/storage-datatypes_gen.go#L213 return a error variable but it's nil
  190. cmd/storage-datatypes_gen.go#L653 return a error variable but it's nil
  191. cmd/storage-datatypes_gen.go#L676 return a error variable but it's nil
  192. cmd/storage-datatypes_gen.go#L840 return a error variable but it's nil
  193. cmd/storage-datatypes_gen.go#L1156 return a error variable but it's nil
  194. cmd/storage-datatypes_gen.go#L1189 return a error variable but it's nil
  195. cmd/storage-datatypes_gen.go#L1508 return a error variable but it's nil
  196. cmd/storage-datatypes_gen.go#L1608 return a error variable but it's nil
  197. cmd/storage-datatypes_gen.go#L1638 return a error variable but it's nil
  198. cmd/storage-datatypes_gen.go#L1744 return a error variable but it's nil
  199. cmd/storage-datatypes_gen.go#L1833 return a error variable but it's nil
  200. cmd/storage-datatypes_gen.go#L2122 return a error variable but it's nil
  201. cmd/storage-datatypes_gen.go#L2520 return a error variable but it's nil
  202. cmd/storage-datatypes_gen.go#L2703 return a error variable but it's nil
  203. cmd/storage-datatypes_gen.go#L2766 return a error variable but it's nil
  204. cmd/storage-datatypes_gen.go#L2977 return a error variable but it's nil
  205. cmd/storage-datatypes_gen.go#L3303 return a error variable but it's nil
  206. cmd/storage-datatypes_gen.go#L3832 return a error variable but it's nil
  207. cmd/storage-datatypes_gen.go#L3864 return a error variable but it's nil
  208. cmd/storage-datatypes_gen.go#L4176 return a error variable but it's nil
  209. cmd/storage-datatypes_gen.go#L4358 return a error variable but it's nil
  210. cmd/storage-datatypes_gen.go#L4439 return a error variable but it's nil
  211. cmd/storage-datatypes_gen.go#L4695 return a error variable but it's nil
  212. cmd/storage-datatypes_gen.go#L4771 return a error variable but it's nil
  213. cmd/storage-datatypes_gen.go#L5430 return a error variable but it's nil
  214. cmd/storage-datatypes_gen.go#L5467 return a error variable but it's nil
  215. cmd/storage-datatypes_gen.go#L5636 return a error variable but it's nil
  216. cmd/storage-datatypes_gen.go#L5650 return a error variable but it's nil
  217. cmd/storage-datatypes_gen.go#L5759 return a error variable but it's nil
  218. cmd/storage-datatypes_gen.go#L5935 return a error variable but it's nil
  219. cmd/storage-datatypes_gen.go#L6092 return a error variable but it's nil
  220. cmd/storage-datatypes_gen.go#L6294 return a error variable but it's nil
  221. cmd/storage-datatypes_gen.go#L6442 return a error variable but it's nil
  222. cmd/storage-datatypes_gen.go#L6519 return a error variable but it's nil
  223. cmd/storage-datatypes_gen.go#L6539 return a error variable but it's nil
  224. cmd/storage-datatypes_gen.go#L6575 return a error variable but it's nil
  225. cmd/storage-datatypes_gen.go#L6806 return a error variable but it's nil
  226. cmd/tier-last-day-stats_gen.go#L332 return a error variable but it's nil
  227. cmd/update.go#L110 return a error variable but it's nil
  228. cmd/warm-backend.go#L90 return a error variable but it's nil
  229. cmd/xl-storage-format-v1_gen.go#L20 return a error variable but it's nil
  230. cmd/xl-storage-format-v1_gen.go#L30 return a error variable but it's nil
  231. cmd/xl-storage-format-v1_gen.go#L52 return a error variable but it's nil
  232. cmd/xl-storage-format-v1_gen.go#L145 return a error variable but it's nil
  233. cmd/xl-storage-format-v1_gen.go#L696 return a error variable but it's nil
  234. cmd/xl-storage-format-v1_gen.go#L1104 return a error variable but it's nil
  235. cmd/xl-storage-format-v1_gen.go#L1275 return a error variable but it's nil
  236. cmd/xl-storage-format-v1_gen.go#L1609 return a error variable but it's nil
  237. cmd/xl-storage-format-v2-legacy.go#L82 return a error variable but it's nil
  238. cmd/xl-storage-format-v2-legacy.go#L182 return a error variable but it's nil
  239. cmd/xl-storage-format-v2-legacy.go#L231 return a error variable but it's nil
  240. cmd/xl-storage-format-v2.go#L809 return a error variable but it's nil
  241. cmd/xl-storage-format-v2_gen.go#L20 return a error variable but it's nil
  242. cmd/xl-storage-format-v2_gen.go#L30 return a error variable but it's nil
  243. cmd/xl-storage-format-v2_gen.go#L52 return a error variable but it's nil
  244. cmd/xl-storage-format-v2_gen.go#L72 return a error variable but it's nil
  245. cmd/xl-storage-format-v2_gen.go#L82 return a error variable but it's nil
  246. cmd/xl-storage-format-v2_gen.go#L104 return a error variable but it's nil
  247. cmd/xl-storage-format-v2_gen.go#L124 return a error variable but it's nil
  248. cmd/xl-storage-format-v2_gen.go#L134 return a error variable but it's nil
  249. cmd/xl-storage-format-v2_gen.go#L156 return a error variable but it's nil
  250. cmd/xl-storage-format-v2_gen.go#L176 return a error variable but it's nil
  251. cmd/xl-storage-format-v2_gen.go#L186 return a error variable but it's nil
  252. cmd/xl-storage-format-v2_gen.go#L208 return a error variable but it's nil
  253. cmd/xl-storage-format-v2_gen.go#L228 return a error variable but it's nil
  254. cmd/xl-storage-format-v2_gen.go#L238 return a error variable but it's nil
  255. cmd/xl-storage-format-v2_gen.go#L260 return a error variable but it's nil
  256. cmd/xl-storage-format-v2_gen.go#L366 return a error variable but it's nil
  257. cmd/xl-storage-format-v2_gen.go#L615 return a error variable but it's nil
  258. cmd/xl-storage-format-v2_gen.go#L1123 return a error variable but it's nil
  259. cmd/xl-storage-format-v2_gen.go#L1989 return a error variable but it's nil
  260. cmd/xl-storage-format-v2_gen.go#L2068 return a error variable but it's nil
  261. cmd/xl-storage-format-v2_gen.go#L2336 return a error variable but it's nil
  262. cmd/xl-storage-format-v2_gen.go#L2381 return a error variable but it's nil
  263. cmd/xl-storage-format-v2_gen.go#L2455 return a error variable but it's nil
  264. cmd/data-usage_test.go#L286 return a error variable but it's nil
  265. cmd/data-usage_test.go#L576 return a error variable but it's nil
  266. internal/config/certs_test.go#L41 return a error variable but it's nil
  267. internal/grid/grid_types_msgp_test.go#L73 return a error variable but it's nil
  268. internal/grid/grid_types_msgp_test.go#L262 return a error variable but it's nil

Report issue: https://github.com/minio/minio/issues

Copy link

Run sundrylint on Repo: https://github.com/jesseduffield/lazydocker

Got total 3 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329447929

Expand
  1. pkg/utils/utils.go#L401 return a error variable but it's nil
  2. pkg/commands/docker.go#L404 return a error variable but it's nil
  3. pkg/commands/errors.go#L20 return a error variable but it's nil

Report issue: https://github.com/jesseduffield/lazydocker/issues

Copy link

Run sundrylint on Repo: https://github.com/prometheus/prometheus

Got total 2 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329446560

Expand
  1. discovery/uyuni/uyuni.go#L211 return a error variable but it's nil
  2. promql/query_logger.go#L131 return a error variable but it's nil

Report issue: https://github.com/prometheus/prometheus/issues

Copy link

Run sundrylint on Repo: https://github.com/pocketbase/pocketbase

Got total 5 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329447881

Expand
  1. core/validators/db.go#L50 return a error variable but it's nil
  2. tools/tokenizer/tokenizer.go#L102 return a error variable but it's nil
  3. tools/mailer/sendmail.go#L94 return a error variable but it's nil
  4. tools/search/filter.go#L290 return a error variable but it's nil
  5. plugins/jsvm/binds.go#L645 return a error variable but it's nil

Report issue: https://github.com/pocketbase/pocketbase/issues

Copy link

Run sundrylint on Repo: https://github.com/docker/compose

Got total 11 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329447833

Expand
  1. pkg/api/dryrunclient.go#L142 return a error variable but it's nil
  2. pkg/compose/attach.go#L61 return a error variable but it's nil
  3. pkg/compose/build_bake.go#L82 return a error variable but it's nil
  4. pkg/compose/convergence.go#L594 return a error variable but it's nil
  5. pkg/compose/convergence.go#L642 return a error variable but it's nil
  6. pkg/compose/cp.go#L141 return a error variable but it's nil
  7. pkg/compose/cp.go#L144 return a error variable but it's nil
  8. pkg/compose/wait.go#L66 return a error variable but it's nil
  9. pkg/remote/git.go#L43 return a error variable but it's nil
  10. pkg/remote/oci.go#L45 return a error variable but it's nil
  11. cmd/compose/compose.go#L377 return a error variable but it's nil

Report issue: https://github.com/docker/compose/issues

Copy link

Run sundrylint on Repo: https://github.com/hashicorp/terraform

Got total 9 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329447297

Expand
  1. internal/plans/changes.go#L294 return a error variable but it's nil
  2. internal/plans/changes.go#L533 return a error variable but it's nil
  3. internal/command/jsonstate/state.go#L166 return a error variable but it's nil
  4. internal/backend/remote/backend_state.go#L104 return a error variable but it's nil
  5. internal/communicator/ssh/http_proxy.go#L154 return a error variable but it's nil
  6. internal/cloudplugin/binary.go#L183 return a error variable but it's nil
  7. internal/command/meta_backend_migrate.go#L557 return a error variable but it's nil
  8. internal/command/show.go#L319 return a error variable but it's nil
  9. internal/rpcapi/dependencies.go#L59 return a error variable but it's nil

Report issue: https://github.com/hashicorp/terraform/issues

Copy link

Run sundrylint on Repo: https://github.com/gofiber/fiber

Got total 7 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329448108

Expand
  1. redirect_msgp.go#L105 return a error variable but it's nil
  2. middleware/cache/manager_msgp.go#L192 return a error variable but it's nil
  3. middleware/session/data_msgp.go#L46 return a error variable but it's nil
  4. middleware/csrf/storage_manager_msgp.go#L46 return a error variable but it's nil
  5. middleware/csrf/storage_manager_msgp.go#L131 return a error variable but it's nil
  6. middleware/idempotency/response_msgp.go#L145 return a error variable but it's nil
  7. middleware/limiter/manager_msgp.go#L89 return a error variable but it's nil

Report issue: https://github.com/gofiber/fiber/issues

Copy link

Run sundrylint on Repo: https://github.com/beego/beego

Got total 41 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329448031

Expand
  1. client/httplib/httplib.go#L503 return a error variable but it's nil
  2. client/orm/internal/utils/utils.go#L98 return a error variable but it's nil
  3. client/orm/internal/utils/utils.go#L136 return a error variable but it's nil
  4. client/orm/internal/models/models_info_f.go#L486 return a error variable but it's nil
  5. client/orm/db.go#L806 return a error variable but it's nil
  6. core/config/etcd/config.go#L187 return a error variable but it's nil
  7. core/config/yaml/yaml.go#L51 return a error variable but it's nil
  8. core/config/yaml/yaml.go#L84 return a error variable but it's nil
  9. core/logs/alils/log_project.go#L85 return a error variable but it's nil
  10. core/logs/alils/log_project.go#L123 return a error variable but it's nil
  11. core/logs/alils/log_project.go#L177 return a error variable but it's nil
  12. core/logs/alils/log_project.go#L208 return a error variable but it's nil
  13. core/logs/alils/log_project.go#L260 return a error variable but it's nil
  14. core/logs/alils/log_project.go#L313 return a error variable but it's nil
  15. core/logs/alils/log_project.go#L351 return a error variable but it's nil
  16. core/logs/alils/log_project.go#L390 return a error variable but it's nil
  17. core/logs/alils/log_project.go#L429 return a error variable but it's nil
  18. core/logs/alils/log_project.go#L460 return a error variable but it's nil
  19. core/logs/alils/log_project.go#L511 return a error variable but it's nil
  20. core/logs/alils/log_project.go#L549 return a error variable but it's nil
  21. core/logs/alils/log_project.go#L588 return a error variable but it's nil
  22. core/logs/alils/log_project.go#L627 return a error variable but it's nil
  23. core/logs/alils/log_project.go#L658 return a error variable but it's nil
  24. core/logs/alils/log_project.go#L703 return a error variable but it's nil
  25. core/logs/alils/log_project.go#L748 return a error variable but it's nil
  26. core/logs/alils/log_project.go#L780 return a error variable but it's nil
  27. core/logs/alils/log_project.go#L812 return a error variable but it's nil
  28. core/logs/alils/log_store.go#L71 return a error variable but it's nil
  29. core/logs/alils/log_store.go#L118 return a error variable but it's nil
  30. core/logs/alils/log_store.go#L165 return a error variable but it's nil
  31. core/logs/alils/log_store.go#L239 return a error variable but it's nil
  32. core/logs/alils/log_store.go#L250 return a error variable but it's nil
  33. core/logs/alils/log_store.go#L269 return a error variable but it's nil
  34. core/logs/alils/machine_group.go#L84 return a error variable but it's nil
  35. core/logs/alils/request.go#L61 return a error variable but it's nil
  36. core/logs/alils/signature.go#L110 return a error variable but it's nil
  37. core/validation/util.go#L173 return a error variable but it's nil
  38. server/web/session/session.go#L237 return a error variable but it's nil
  39. server/web/controller.go#L305 return a error variable but it's nil
  40. server/web/template.go#L292 return a error variable but it's nil
  41. test/bindata.go#L38 return a error variable but it's nil

Report issue: https://github.com/beego/beego/issues

Copy link

Run sundrylint on Repo: https://github.com/labstack/echo

Got total 4 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329448323

Expand
  1. context.go#L499 return a error variable but it's nil
  2. echo.go#L996 return a error variable but it's nil
  3. bind_test.go#L1155 return a error variable but it's nil
  4. bind_test.go#L1262 return a error variable but it's nil

Report issue: https://github.com/labstack/echo/issues

Copy link

Run sundrylint on Repo: https://github.com/traefik/traefik

Got total 9 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329446925

Expand
  1. pkg/types/tracing.go#L86 return a error variable but it's nil
  2. pkg/tls/certificate.go#L136 return a error variable but it's nil
  3. pkg/provider/consulcatalog/consul_catalog.go#L385 return a error variable but it's nil
  4. pkg/provider/docker/pswarm.go#L218 return a error variable but it's nil
  5. pkg/provider/docker/pswarm.go#L291 return a error variable but it's nil
  6. pkg/collector/collector.go#L73 return a error variable but it's nil
  7. pkg/proxy/fast/proxy_websocket_test.go#L682 return a error variable but it's nil
  8. pkg/proxy/httputil/proxy_websocket_test.go#L577 return a error variable but it's nil
  9. pkg/server/server_entrypoint_tcp_test.go#L157 return a error variable but it's nil

Report issue: https://github.com/traefik/traefik/issues

Copy link

Run sundrylint on Repo: https://github.com/v2fly/v2ray-core

Got total 10 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329448230

Expand
  1. common/cmdarg/arg.go#L16 return a error variable but it's nil
  2. common/cmdarg/arg.go#L25 return a error variable but it's nil
  3. transport/internet/system_listener.go#L138 return a error variable but it's nil
  4. transport/internet/system_listener.go#L145 return a error variable but it's nil
  5. transport/internet/tls/config_other.go#L52 return a error variable but it's nil
  6. proxy/http/client.go#L327 return a error variable but it's nil
  7. transport/internet/dtls/listener.go#L139 return a error variable but it's nil
  8. transport/internet/dtls/listener.go#L168 return a error variable but it's nil
  9. transport/internet/request/assembler/packetconn/packetbundle.go#L41 return a error variable but it's nil
  10. transport/internet/request/assembler/simple/server.go#L97 return a error variable but it's nil

Report issue: https://github.com/v2fly/v2ray-core/issues

Copy link

Run sundrylint on Repo: https://github.com/go-gitea/gitea

Got total 50 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329447398

Expand
  1. modules/setting/path.go#L56 return a error variable but it's nil
  2. models/auth/oauth2.go#L410 return a error variable but it's nil
  3. modules/git/repo_commit.go#L504 return a error variable but it's nil
  4. modules/git/repo_compare.go#L329 return a error variable but it's nil
  5. modules/git/repo_index.go#L102 return a error variable but it's nil
  6. modules/git/tree.go#L63 return a error variable but it's nil
  7. modules/charset/charset.go#L206 return a error variable but it's nil
  8. modules/charset/charset.go#L210 return a error variable but it's nil
  9. models/user/external_login_user.go#L124 return a error variable but it's nil
  10. models/repo/attachment.go#L164 return a error variable but it's nil
  11. models/repo/release.go#L405 return a error variable but it's nil
  12. models/repo/repo.go#L767 return a error variable but it's nil
  13. models/actions/tasks_version.go#L39 return a error variable but it's nil
  14. models/asymkey/gpg_key.go#L113 return a error variable but it's nil
  15. modules/lfs/content_store.go#L44 return a error variable but it's nil
  16. models/git/branch.go#L274 return a error variable but it's nil
  17. models/git/protected_branch.go#L533 return a error variable but it's nil
  18. models/unittest/fixtures.go#L75 return a error variable but it's nil
  19. models/migrations/v1_11/v111.go#L170 return a error variable but it's nil
  20. models/migrations/v1_11/v111.go#L182 return a error variable but it's nil
  21. models/migrations/v1_11/v111.go#L188 return a error variable but it's nil
  22. models/migrations/v1_11/v111.go#L228 return a error variable but it's nil
  23. models/migrations/v1_11/v111.go#L258 return a error variable but it's nil
  24. models/pull/review_state.go#L117 return a error variable but it's nil
  25. models/issues/assignees.go#L139 return a error variable but it's nil
  26. models/issues/content_history.go#L179 return a error variable but it's nil
  27. models/issues/issue_update.go#L485 return a error variable but it's nil
  28. models/issues/issue_update.go#L589 return a error variable but it's nil
  29. models/issues/issue_update.go#L619 return a error variable but it's nil
  30. models/issues/review.go#L187 return a error variable but it's nil
  31. models/issues/review.go#L214 return a error variable but it's nil
  32. models/issues/review.go#L571 return a error variable but it's nil
  33. models/migrations/v1_6/v70.go#L109 return a error variable but it's nil
  34. modules/lfstransfer/backend/util.go#L129 return a error variable but it's nil
  35. models/activities/notification.go#L216 return a error variable but it's nil
  36. modules/private/internal.go#L81 return a error variable but it's nil
  37. services/gitdiff/gitdiff.go#L842 return a error variable but it's nil
  38. models/repo.go#L316 return a error variable but it's nil
  39. services/issue/assignee.go#L60 return a error variable but it's nil
  40. services/issue/assignee.go#L84 return a error variable but it's nil
  41. services/issue/assignee.go#L275 return a error variable but it's nil
  42. services/pull/merge_rebase.go#L35 return a error variable but it's nil
  43. services/auth/source/ldap/source_search.go#L146 return a error variable but it's nil
  44. services/auth/source/oauth2/providers.go#L189 return a error variable but it's nil
  45. modules/activitypub/client.go#L95 return a error variable but it's nil
  46. modules/activitypub/user_settings.go#L31 return a error variable but it's nil
  47. modules/activitypub/user_settings.go#L35 return a error variable but it's nil
  48. routers/api/v1/activitypub/reqsignature.go#L85 return a error variable but it's nil
  49. services/migrations/gitlab.go#L215 return a error variable but it's nil
  50. routers/api/v1/repo/issue_label.go#L358 return a error variable but it's nil

Report issue: https://github.com/go-gitea/gitea/issues

Copy link

Run sundrylint on Repo: https://github.com/zeromicro/go-zero

Got total 2 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329448280

Expand
  1. core/iox/pipe.go#L22 return a error variable but it's nil
  2. core/filex/rangereader.go#L48 return a error variable but it's nil

Report issue: https://github.com/zeromicro/go-zero/issues

Copy link

Run sundrylint on Repo: https://github.com/helm/helm

Got total 16 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329448264

Expand
  1. internal/tlsutil/tls.go#L77 return a error variable but it's nil
  2. internal/third_party/k8s.io/kubernetes/deployment/util/deploymentutil.go#L128 return a error variable but it's nil
  3. pkg/kube/client.go#L857 return a error variable but it's nil
  4. pkg/kube/roundtripper.go#L44 return a error variable but it's nil
  5. pkg/kube/roundtripper.go#L47 return a error variable but it's nil
  6. pkg/kube/roundtripper.go#L52 return a error variable but it's nil
  7. pkg/kube/roundtripper.go#L61 return a error variable but it's nil
  8. pkg/kube/roundtripper.go#L64 return a error variable but it's nil
  9. pkg/kube/roundtripper.go#L74 return a error variable but it's nil
  10. pkg/registry/client.go#L696 return a error variable but it's nil
  11. pkg/downloader/manager.go#L742 return a error variable but it's nil
  12. pkg/downloader/manager.go#L747 return a error variable but it's nil
  13. pkg/action/list.go#L216 return a error variable but it's nil
  14. pkg/cli/values/options.go#L91 return a error variable but it's nil
  15. pkg/cli/values/options.go#L146 return a error variable but it's nil
  16. pkg/plugin/installer/vcs_installer.go#L66 return a error variable but it's nil

Report issue: https://github.com/helm/helm/issues

Copy link

Run sundrylint on Repo: https://github.com/go-kit/kit

Got total 1 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329448483

Expand
  1. transport/awslambda/handler_test.go#L310 return a error variable but it's nil

Report issue: https://github.com/go-kit/kit/issues

Copy link

Run sundrylint on Repo: https://github.com/gohugoio/hugo

Got total 18 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329446338

Expand
  1. hugofs/decorators.go#L149 return a error variable but it's nil
  2. modules/client.go#L444 return a error variable but it's nil
  3. modules/client.go#L539 return a error variable but it's nil
  4. markup/markup_config/config.go#L64 return a error variable but it's nil
  5. markup/rst/convert.go#L109 return a error variable but it's nil
  6. minifiers/config.go#L134 return a error variable but it's nil
  7. config/allconfig/load.go#L456 return a error variable but it's nil
  8. cache/dynacache/dynacache.go#L406 return a error variable but it's nil
  9. cache/dynacache/dynacache.go#L423 return a error variable but it's nil
  10. publisher/htmlElementsCollector.go#L445 return a error variable but it's nil
  11. resources/resource_transformers/tocss/dartsass/client.go#L128 return a error variable but it's nil
  12. resources/resource_factories/create/create.go#L181 return a error variable but it's nil
  13. tpl/tplimpl/template.go#L737 return a error variable but it's nil
  14. hugolib/hugo_sites_build.go#L1119 return a error variable but it's nil
  15. hugolib/site.go#L1505 return a error variable but it's nil
  16. hugolib/site.go#L1564 return a error variable but it's nil
  17. hugolib/site.go#L1557 return a error variable but it's nil
  18. commands/hugobuilder.go#L481 return a error variable but it's nil

Report issue: https://github.com/gohugoio/hugo/issues

Copy link

Run sundrylint on Repo: https://github.com/istio/istio

Got total 21 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329447609

Expand
  1. pkg/util/protomarshal/protomarshal.go#L79 return a error variable but it's nil
  2. pkg/util/protomarshal/protomarshal.go#L88 return a error variable but it's nil
  3. pkg/istio-agent/grpcxds/grpc_bootstrap.go#L146 return a error variable but it's nil
  4. pkg/istio-agent/grpcxds/grpc_bootstrap.go#L204 return a error variable but it's nil
  5. pkg/webhooks/webhookpatch.go#L167 return a error variable but it's nil
  6. istioctl/pkg/util/handlers/handlers.go#L78 return a error variable but it's nil
  7. pkg/wasm/cache.go#L216 return a error variable but it's nil
  8. pkg/wasm/imagefetcher.go#L166 return a error variable but it's nil
  9. pkg/adsc/adsc.go#L239 return a error variable but it's nil
  10. istioctl/pkg/kubeinject/kubeinject.go#L300 return a error variable but it's nil
  11. istioctl/pkg/proxyconfig/proxyconfig.go#L152 return a error variable but it's nil
  12. istioctl/pkg/ztunnelconfig/ztunnelconfig.go#L570 return a error variable but it's nil
  13. tools/bug-report/pkg/content/content.go#L246 return a error variable but it's nil
  14. pilot/cmd/pilot-agent/options/security.go#L66 return a error variable but it's nil
  15. security/pkg/pki/ra/common.go#L174 return a error variable but it's nil
  16. security/pkg/pki/ra/k8s_ra.go#L86 return a error variable but it's nil
  17. pilot/pkg/bootstrap/istio_ca.go#L569 return a error variable but it's nil
  18. pkg/test/framework/components/authz/server.go#L77 return a error variable but it's nil
  19. pkg/test/framework/components/authz/server.go#L95 return a error variable but it's nil
  20. pkg/test/framework/components/jwt/server.go#L61 return a error variable but it's nil
  21. pkg/config/analysis/analyzers/analyzers_test.go#L1149 return a error variable but it's nil

Report issue: https://github.com/istio/istio/issues

Copy link

Run sundrylint on Repo: https://github.com/getsops/sops

Got total 6 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12329452950

Expand
  1. version/version.go#L138 return a error variable but it's nil
  2. cmd/sops/decrypt.go#L70 return a error variable but it's nil
  3. cmd/sops/decrypt.go#L87 return a error variable but it's nil
  4. cmd/sops/encrypt.go#L123 return a error variable but it's nil
  5. cmd/sops/set.go#L64 return a error variable but it's nil
  6. cmd/sops/unset.go#L66 return a error variable but it's nil

Report issue: https://github.com/getsops/sops/issues

Copy link

Run sundrylint on Repo: https://github.com/ergo-services/ergo

Got total 2 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12331442060

Expand
  1. lib/compress.go#L126 return a error variable but it's nil
  2. lib/compress.go#L144 return a error variable but it's nil

Report issue: https://github.com/ergo-services/ergo/issues

Copy link

Run sundrylint on Repo: https://github.com/vmware/govmomi

Got total 2 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12331441718

Expand
  1. cli/flags/datacenter.go#L132 return a error variable but it's nil
  2. cli/fields/info.go#L137 return a error variable but it's nil

Report issue: https://github.com/vmware/govmomi/issues

Copy link

Run sundrylint on Repo: https://github.com/absmach/magistrala

Got total 3 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12331441142

Expand
  1. auth/jwt/tokenizer.go#L130 return a error variable but it's nil
  2. bootstrap/events/producer/streams.go#L44 return a error variable but it's nil
  3. bootstrap/events/producer/streams.go#L60 return a error variable but it's nil

Report issue: https://github.com/absmach/magistrala/issues

Copy link

Run sundrylint on Repo: https://github.com/unidoc/unipdf

Got total 2 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12331446515

Expand
  1. internal/cmap/bcmaps/bcmaps.go#L156 return a error variable but it's nil
  2. model/internal/colorprofile/colorprofile.go#L39 return a error variable but it's nil

Report issue: https://github.com/unidoc/unipdf/issues

Copy link

Run sundrylint on Repo: https://github.com/thought-machine/please

Got total 1 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12331446599

Expand
  1. tools/build_langserver/lsp/lsp_test.go#L615 return a error variable but it's nil

Report issue: https://github.com/thought-machine/please/issues

Copy link

Run sundrylint on Repo: https://github.com/activecm/rita

Got total 1 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12331443425

Expand
  1. database/tables.go#L1575 return a error variable but it's nil

Report issue: https://github.com/activecm/rita/issues

Copy link

Run sundrylint on Repo: https://github.com/kubernetes-sigs/kwok

Got total 1 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12331448779

Expand
  1. pkg/utils/file/download.go#L129 return a error variable but it's nil

Report issue: https://github.com/kubernetes-sigs/kwok/issues

Copy link

Run sundrylint on Repo: https://github.com/kcp-dev/kcp

Got total 2 lines output in action: https://github.com/alingse/sundrylint/actions/runs/12331447142

Expand
  1. pkg/reconciler/apis/apibindingdeletion/apibinding_deletor.go#L121 return a error variable but it's nil
  2. pkg/server/controllers.go#L416 return a error variable but it's nil

Report issue: https://github.com/kcp-dev/kcp/issues

@ccoVeille
Copy link

Where is the code of nilness?

@ccoVeille
Copy link

Found it

https://github.com/alingse/nilnesserr

@Giulio2002
Copy link

holy shit, you made a lint bot and just spammed everyone with linting stuff. gg

@alingse
Copy link
Owner Author

alingse commented Dec 16, 2024

Where is the code of nilness?
@ccoVeille
Yes , I want create a repo to implement a single-clean linter nilnesserr, there is still some bug when I research it.

  1. original code https://cs.opensource.google/go/x/tools/+/master:go/analysis/passes/nilness/nilness.go
  2. modified code https://github.com/alingse/sundrylint/blob/main/nilnesserr.go
  3. code in future https://github.com/alingse/nilnesserr

This project, sundrylint, is just an experimental idea or a pre-implementation linter code. I run go-linter-runner to check whether this idea is adequate. If there are indeed some bugs, I may create a linter or merge this idea into other linters.

You can see the details at #2. There are six ideas mentioned, but only rangeappendall and nilnesserr have some value to others.

@alingse
Copy link
Owner Author

alingse commented Dec 16, 2024

holy shit, you made a lint bot and just spammed everyone with linting stuff. gg

Yes, I use go-linter-runner to test my ideas on public GitHub Go repositories. However, in this issue, the linter implementation isn’t very effective, so the output comments above may not have this bug.

You can visit go-linter-runner-example to see how it is used

AskAlexSharov pushed a commit to erigontech/erigon that referenced this issue Dec 17, 2024
the `err` has been checked. so it's value must be nil, so should return
`r.err`

I have an idea to detect code that returns a non-relevant nilness error
bug. I checked the top 1000 GitHub Go repositories and found this, all
result listed in alingse/sundrylint#4

Signed-off-by: alingse <[email protected]>
@alingse alingse closed this as completed Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@ccoVeille @alingse @Giulio2002 and others