Add location sliders to font overview #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Work in progress: Screen.Recording.2025-01-16.at.01.27.09.mp4 |
justvanrossum
force-pushed
the
issue-1948-font-overview-add-location-sliders
branch
from
1338ad1 to
8e0077d
Compare
justvanrossum
deleted the
issue-1948-font-overview-add-location-sliders
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1948
Draft PR for feedback.
Do you mind to give me a hint how I can make the sliders change when changing the font source via the dropdown? It should work equal to the editor view when changing the source of a glyph, but I was not able to figure out how you implemented it.