Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background layers, part 2 #1844

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/fontra/client/lang/de.js
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,7 @@ export const strings = {
"sidebar.designspace-navigation.glyph-axes": "Glyph-Achsen",
"sidebar.designspace-navigation.glyph-axes.edit": "Glyph-Achsen bearbeiten",
"sidebar.designspace-navigation.glyph-axes.reset": "Glyph-Achsen zurücksetzen",
"sidebar.designspace-navigation.glyph-source-layers": "Source layers",
"sidebar.designspace-navigation.glyph-sources": "Glyph-Sourcen",
"sidebar.designspace-navigation.glyph-sources.name": "Source Name",
"sidebar.designspace-navigation.glyph-sources.status": "Status",
Expand Down
1 change: 1 addition & 0 deletions src/fontra/client/lang/en.js
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,7 @@ export const strings = {
"sidebar.designspace-navigation.glyph-axes": "Glyph axes",
"sidebar.designspace-navigation.glyph-axes.edit": "Edit glyph axes",
"sidebar.designspace-navigation.glyph-axes.reset": "Reset glyph axes",
"sidebar.designspace-navigation.glyph-source-layers": "Source layers",
"sidebar.designspace-navigation.glyph-sources": "Glyph sources",
"sidebar.designspace-navigation.glyph-sources.name": "source name",
"sidebar.designspace-navigation.glyph-sources.status": "status",
Expand Down
1 change: 1 addition & 0 deletions src/fontra/client/lang/fr.js
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,7 @@ export const strings = {
"sidebar.designspace-navigation.glyph-axes": "Axes du glyphe",
"sidebar.designspace-navigation.glyph-axes.edit": "Éditer les axes du glyphe",
"sidebar.designspace-navigation.glyph-axes.reset": "Réinitialiser les axes du glyphe",
"sidebar.designspace-navigation.glyph-source-layers": "Source layers",
"sidebar.designspace-navigation.glyph-sources": "Sources du glyphe",
"sidebar.designspace-navigation.glyph-sources.name": "nom de la source",
"sidebar.designspace-navigation.glyph-sources.status": "statut",
Expand Down
1 change: 1 addition & 0 deletions src/fontra/client/lang/ja.js
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,7 @@ export const strings = {
"sidebar.designspace-navigation.glyph-axes": "グリフの補完軸",
"sidebar.designspace-navigation.glyph-axes.edit": "グリフの補完軸を編集",
"sidebar.designspace-navigation.glyph-axes.reset": "グリフの補完軸をリセット",
"sidebar.designspace-navigation.glyph-source-layers": "Source layers",
"sidebar.designspace-navigation.glyph-sources": "グリフソース",
"sidebar.designspace-navigation.glyph-sources.name": "ソース名",
"sidebar.designspace-navigation.glyph-sources.status": "ステータス",
Expand Down
1 change: 1 addition & 0 deletions src/fontra/client/lang/nl.js
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,7 @@ export const strings = {
"sidebar.designspace-navigation.glyph-axes": "Glyph assen",
"sidebar.designspace-navigation.glyph-axes.edit": "Wijzig glyph assen",
"sidebar.designspace-navigation.glyph-axes.reset": "Reset glyph assen",
"sidebar.designspace-navigation.glyph-source-layers": "Source layers",
"sidebar.designspace-navigation.glyph-sources": "Glyph sources",
"sidebar.designspace-navigation.glyph-sources.name": "sourcenaam",
"sidebar.designspace-navigation.glyph-sources.status": "status",
Expand Down
1 change: 1 addition & 0 deletions src/fontra/client/lang/zh-CN.js
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,7 @@ export const strings = {
"sidebar.designspace-navigation.glyph-axes": "字形参数轴",
"sidebar.designspace-navigation.glyph-axes.edit": "编辑字形参数轴",
"sidebar.designspace-navigation.glyph-axes.reset": "重置字形参数轴",
"sidebar.designspace-navigation.glyph-source-layers": "Source layers",
"sidebar.designspace-navigation.glyph-sources": "字形源",
"sidebar.designspace-navigation.glyph-sources.name": "源名称",
"sidebar.designspace-navigation.glyph-sources.status": "状态",
Expand Down
4 changes: 2 additions & 2 deletions src/fontra/views/editor/editor.js
Original file line number Diff line number Diff line change
Expand Up @@ -1397,8 +1397,8 @@ export class EditorController extends ViewController {
{ actionIdentifier: "action.select-next-glyph" },
{ actionIdentifier: "action.select-previous-source" },
{ actionIdentifier: "action.select-next-source" },
// { actionIdentifier: "action.select-previous-source-layer" },
// { actionIdentifier: "action.select-next-source-layer" },
{ actionIdentifier: "action.select-previous-source-layer" },
{ actionIdentifier: "action.select-next-source-layer" },
],
});

Expand Down
6 changes: 1 addition & 5 deletions src/fontra/views/editor/panel-designspace-navigation.js
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ export default class DesignspaceNavigationPanel extends Panel {
},
{
id: "glyph-layers-accordion-item",
label: "Source layers", // XXXX TODO add translate strings
label: translate("sidebar.designspace-navigation.glyph-source-layers"),
open: true,
content: html.div(
{
Expand Down Expand Up @@ -830,10 +830,6 @@ export default class DesignspaceNavigationPanel extends Panel {
}

async _updateSourceLayersList() {
// TODO: the background layers feature is not yet functional, disable for now
this.glyphLayersAccordionItem.hidden = true;
return;

const sourceIndex = this.sceneModel.sceneSettings.selectedSourceIndex;
const haveLayers =
this.sceneModel.selectedGlyph?.isEditing && sourceIndex != undefined;
Expand Down
Loading