Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped grpc v1.54.0->v1.55.0 and required deps #3022

Closed
wants to merge 1 commit into from

Conversation

mhutchinson
Copy link
Contributor

This required an explicit command to get a new version of otel, by default it was trying to install v1.6.1 which is pretty old

go get go.opentelemetry.io/otel/exporters/otlp/otlptrace/[email protected]

This replaces #2991.

This required an explicit command to get a new version of otel, by default it was trying to install v1.6.1 which is pretty old

`go get go.opentelemetry.io/otel/exporters/otlp/otlptrace/[email protected]`

This replaces google#2991.
@mhutchinson mhutchinson requested a review from a team as a code owner June 6, 2023 08:57
@mhutchinson mhutchinson requested a review from jiggoha June 6, 2023 08:57
@mhutchinson
Copy link
Contributor Author

mhutchinson commented Jun 6, 2023

This doesn't fix the etcd issue in #2991 which is blocking us from updating grpc. Closing this. The lesson here is that if we find ourselves getting errors like the following then updating the transitive dependency using the command above helps:

# go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal/tracetransform
../../go/pkg/mod/go.opentelemetry.io/otel/exporters/otlp/[email protected]/internal/tracetransform/instrumentation.go:22:67: undefined: v1.InstrumentationLibrary
../../go/pkg/mod/go.opentelemetry.io/otel/exporters/otlp/[email protected]/internal/tracetransform/instrumentation.go:26:19: undefined: v1.InstrumentationLibrary
../../go/pkg/mod/go.opentelemetry.io/otel/exporters/otlp/[email protected]/internal/tracetransform/span.go:39:35: undefined: v1.InstrumentationLibrarySpans
../../go/pkg/mod/go.opentelemetry.io/otel/exporters/otlp/[email protected]/internal/tracetransform/span.go:55:19: undefined: v1.InstrumentationLibrarySpans
../../go/pkg/mod/go.opentelemetry.io/otel/exporters/otlp/[email protected]/internal/tracetransform/span.go:70:5: unknown field 'InstrumentationLibrarySpans' in struct literal of type "go.opentelemetry.io/proto/otlp/trace/v1".ResourceSpans
../../go/pkg/mod/go.opentelemetry.io/otel/exporters/otlp/[email protected]/internal/tracetransform/span.go:70:45: undefined: v1.InstrumentationLibrarySpans
../../go/pkg/mod/go.opentelemetry.io/otel/exporters/otlp/[email protected]/internal/tracetransform/span.go:83:47: rs.InstrumentationLibrarySpans undefined (type *"go.opentelemetry.io/proto/otlp/trace/v1".ResourceSpans has no field or method InstrumentationLibrarySpans)

@mhutchinson mhutchinson closed this Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants