Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using protoc cli parameter to specify additional class derivations #429

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

tim2CF
Copy link

@tim2CF tim2CF commented Nov 2, 2021

The main feature of this PR is support of additional class instances for all generated types. Parameters for additional class deriving could be passed through protoc command-line argument. Example which enables stock deriving of GHC.Generics.Generic class for all generated haskell types:

--haskell_opt='Opt{ imports = [], pragmas = ["DeriveGeneric"], stockInstances = ["GHC.Generics.Generic"], defaultInstances = [] }'
  • Introduce Data.ProtoLens.Compiler.Parameter module which enables usage of cli parameter from plugin.proto.
  • Using Data.ProtoLens.Compiler.Parameter to enable additional stock deriving (useful for classes like GHC.Generics.Generic).
  • Using Data.ProtoLens.Compiler.Parameter to enable additional default instances implementations (useful for classes which do support default implementations through GHC.Generics.Generic).

@google-cla
Copy link

google-cla bot commented Nov 2, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Nov 2, 2021
@tim2CF
Copy link
Author

tim2CF commented Nov 2, 2021

This is quite small pull request, maybe I could receive some human feedback before google-cla bot approval. If changes could be merged in principle (maybe after some improvements) - then I'll sign cla. Otherwise it does not make much sense.

@blackgnezdo
Copy link
Collaborator

Thanks for the PR. It looks like a useful capability. I pointed out some areas for improvement. In addition to those, please add a test covering this newly added functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants