Fix compile failure for C++17. #361
Open
+2,824
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwhpryor
force-pushed
the
fix_cpp17_failure
branch
6 times, most recently
from
552af75 to
37600dd
Compare
This bizarrely only fails on GitHub's ubuntu compiler. I am unable to reproduce on Mac or Linux, but this seems to fix it. I also don't understand why the build looks green and yet new PRs cause the build to fail. Tested: GitHub actions pass now.
jwhpryor
force-pushed
the
fix_cpp17_failure
branch
from
37600dd to
e108677
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_PUBLIC
Fix compile failure for C++17.
I don't understand why this target is being included in the build at all, however, this will allow it to compile for C++17 irrespective of it doing nothing.
END_PUBLIC