Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MinMagnitude and MaxMagnitude ops #2353

Merged
merged 3 commits into from
Dec 29, 2024

Conversation

johnplatts
Copy link
Contributor

Added the MinMagnitude and MaxMagnitude ops as the upcoming AVX10.2 instruction set will have VMINMAXPH/VMINMAXPS/VMINMAXPD instructions that can carry out the MinMagnitude and MaxMagnitude operations for F16/F32/F64 vectors.

@johnplatts johnplatts force-pushed the hwy_min_max_mag_101024 branch from 18c9d93 to 620fec7 Compare October 11, 2024 02:35
jan-wassenberg
jan-wassenberg previously approved these changes Oct 12, 2024
Copy link
Member

@jan-wassenberg jan-wassenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

hwy/ops/generic_ops-inl.h Show resolved Hide resolved
@johnplatts
Copy link
Contributor Author

@jan-wassenberg Are there any changes that need to be made before this pull request is ready to pull?

Copy link
Member

@jan-wassenberg jan-wassenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I seem to have not yet set the correct label for import, sorry about that.

@copybara-service copybara-service bot merged commit f754bd6 into google:master Dec 29, 2024
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants