Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Walletobjects.php manual dependency #110

Merged

Conversation

razvanphp
Copy link
Contributor

Google Wallet API Client library should not be downloaded and included manually, as it is now installed by composer from github.com/google/apiclient-services, here is the source.

Also, according to Google PHP API Client UPGRADING.md, since version 2.10.0 the Google SDKs classes are namespaced so we should use those.

As discussed in #75

Copy link

google-cla bot commented Feb 3, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

This is handled by composer install. Google PHP SDK now has namespaced classes.
@razvanphp razvanphp force-pushed the update-php-demo-with-namespaces branch from 60032e1 to 2c8f54c Compare February 3, 2024 15:13
@stephenmcd
Copy link
Contributor

Thanks so much Razvan. As you've discovered we recently made the Wallet API available to the various cloud client libraries, and we're currently in the process of updating samples and documentation to reflect this. More than likely we'll use the work you've done here once we make all these changes available, so stay tuned and thanks again.

@razvanphp
Copy link
Contributor Author

Oh, didn't know about the "recently" part, seems I'm here at the right time 🙂

@stephenmcd Are you from the Wallet/Pay team? I opened an issue about missing Enums in the generated PHP SDK, I'm interested in contributing this for including it my lib, do you accept contributions and can you suggest how to do this?

@stephenmcd stephenmcd merged commit 644ec59 into google-wallet:main Mar 13, 2024
1 check passed
@razvanphp razvanphp deleted the update-php-demo-with-namespaces branch March 14, 2024 07:57
@johnksterling
Copy link
Contributor

Oh, didn't know about the "recently" part, seems I'm here at the right time 🙂

@stephenmcd Are you from the Wallet/Pay team? I opened an issue about missing Enums in the generated PHP SDK, I'm interested in contributing this for including it my lib, do you accept contributions and can you suggest how to do this?

@razvanphp Interesting, yeah, that seems to be a cross-language thing, not just php. The discovery generators are converting them to and from strings (and even supporting various formats like snake_case camelCase etc on the way in). We can investigate why that is happening with the cloud publishing folks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants