Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents decimal conversion issues with certain locales #89

Merged
merged 3 commits into from
Jan 16, 2022

Conversation

JlUgia
Copy link
Member

@JlUgia JlUgia commented Sep 10, 2021

/cc @kristoffer-zliide
Addresses #84.

  • Uses Decimal to be consistent about the decimal separator (.)
  • Default to the final payment method type if not specified

@JlUgia JlUgia requested a review from jamesblasco October 5, 2021 17:12
@JlUgia
Copy link
Member Author

JlUgia commented Oct 5, 2021

@jamesblasco are you able to take a quick look to this one?

Copy link
Collaborator

@jamesblasco jamesblasco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a note somewhere in the api that the item amount should use dot as decimal separator?

@JlUgia JlUgia merged commit 4fa27d4 into main Jan 16, 2022
@JlUgia JlUgia deleted the 84-amount-conversion-accuracy branch January 16, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants