Fixes the error where DataResult is called multiple times #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViniciusDeep
reviewed
Sep 4, 2024
pay_android/android/src/main/kotlin/io/flutter/plugins/pay_android/GooglePayHandler.kt
Outdated
Show resolved
Hide resolved
ViniciusDeep
reviewed
Sep 4, 2024
pay_android/android/src/main/kotlin/io/flutter/plugins/pay_android/GooglePayHandler.kt
Outdated
Show resolved
Hide resolved
ViniciusDeep
reviewed
Sep 4, 2024
pay_android/android/src/main/kotlin/io/flutter/plugins/pay_android/GooglePayHandler.kt
Outdated
Show resolved
Hide resolved
ViniciusDeep
reviewed
Sep 4, 2024
This was referenced Sep 4, 2024
Open
dhmaciel
force-pushed
the
fix-resend-data-result-when-sent-already
branch
from
c2eb4bd to
d38dfef
Compare
|
#282 fixes this issue too, so we don't need to include additional tracking. Feel free to take a look and provide feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a crash registered on our Crashlytics related to an issue in the Pay library. It's calling the result more than once, resulting in a crash from the lib.
Testing on the library, I was able to reproduce it:
The solution was to prevent calls for dataResult callback more than one time per instance.
To fix it I created a flag to prevent the dataResult from being called multiple times.