[#109] Handle potential init exceptions and fallback #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
mohsenoid
force-pushed
the
fix/#109-fallback-on-init-exceptions
branch
from
c3351e1 to
49c63d8
Compare
mohsenoid
force-pushed
the
fix/#109-fallback-on-init-exceptions
branch
from
49c63d8 to
0678b26
Compare
mohsenoid
commented
Dec 30, 2024
Comment on lines
+75
to
+82
| this.initialize( | ||
| ButtonOptions.newBuilder() | ||
| .setButtonTheme(theme.value) | ||
| .setButtonType(type.value) | ||
| .setCornerRadius(radiusPixelValue) | ||
| .setAllowedPaymentMethods(allowedPaymentMethods) | ||
| .build() | ||
| ) |
There was a problem hiding this comment.
This block can be broken by "Fatal Exception: java.lang.IllegalStateException" or other potential crashes requiring handling and a potential fallback.
|
I will do a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in this issue #109, this library serves as a Compose UI wrapper for the "PayButton" View, initializing within the Compose function.
It may crash for various reasons; thus, this PR introduces an
onErrorcallback and afallbackUito prevent the client app's payment flow from breaking.