-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/printer: do not set impliedSemi to false in print, while writing newlines #70983
base: master
Are you sure you want to change the base?
go/printer: do not set impliedSemi to false in print, while writing newlines #70983
Conversation
…wlines Fixes golang#70978 Change-Id: I0cc54bd11bb4170235bb5a6d5eb6d8438beada58
This PR (HEAD: a1b463e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/638637. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 1: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/638637. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-12-24T14:37:03Z","revision":"6e2581a971cdef63ed3ea125c3a790bc95a049c9"} Please don’t reply on this GitHub thread. Visit golang.org/cl/638637. |
Message from Mateusz Poliwczak: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/638637. |
Message from Go LUCI: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/638637. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/638637. |
Lets say we are writing an *ast.Ident, and this code causes impliedSemi
to set to false (from true), this doesn't make any sense to me, because
we are writing this ident after adding these newlines, thus impliedSemi
should be still set to true.
Fixes #70978