Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add middleware for audit log #21376

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Jan 3, 2025

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner January 3, 2025 09:14
@stonezdj stonezdj requested a review from wy65701436 January 3, 2025 09:14
@stonezdj stonezdj requested a review from chlins January 3, 2025 09:14
@stonezdj stonezdj added the release-note/new-feature New Harbor Feature label Jan 3, 2025
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.23%. Comparing base (c8c11b4) to head (20f29aa).
Report is 353 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21376      +/-   ##
==========================================
+ Coverage   45.36%   46.23%   +0.86%     
==========================================
  Files         244      247       +3     
  Lines       13333    13883     +550     
  Branches     2719     2875     +156     
==========================================
+ Hits         6049     6419     +370     
- Misses       6983     7127     +144     
- Partials      301      337      +36     
Flag Coverage Δ
unittests 46.23% <ø> (+0.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

@stonezdj stonezdj force-pushed the 24dec31_add_audit_middleware branch from b441639 to 67d065e Compare January 3, 2025 09:17
@stonezdj stonezdj requested a review from reasonerjt January 3, 2025 09:54
@stonezdj stonezdj force-pushed the 24dec31_add_audit_middleware branch 2 times, most recently from 025b830 to f1108d2 Compare January 7, 2025 04:53
@stonezdj stonezdj force-pushed the 24dec31_add_audit_middleware branch 2 times, most recently from 84c3a7a to fe36e3f Compare January 13, 2025 07:14
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj enabled auto-merge (squash) January 14, 2025 03:18
@stonezdj stonezdj force-pushed the 24dec31_add_audit_middleware branch from fe36e3f to 20f29aa Compare January 14, 2025 03:18
@stonezdj stonezdj merged commit 67654f2 into goharbor:main Jan 14, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/new-feature New Harbor Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants