Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Remove unused files #21309

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Dec 12, 2024

Please add comment if there is any file need to be removed

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: stonezdj <[email protected]>
@stonezdj stonezdj requested a review from a team as a code owner December 12, 2024 07:11
@stonezdj stonezdj changed the title Remove unused files [WIP] Remove unused files Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.29%. Comparing base (c8c11b4) to head (9daa81b).
Report is 336 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21309      +/-   ##
==========================================
+ Coverage   45.36%   46.29%   +0.92%     
==========================================
  Files         244      247       +3     
  Lines       13333    13863     +530     
  Branches     2719     2867     +148     
==========================================
+ Hits         6049     6418     +369     
- Misses       6983     7108     +125     
- Partials      301      337      +36     
Flag Coverage Δ
unittests 46.29% <ø> (+0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

@stonezdj stonezdj assigned wy65701436 and unassigned Vad1mo, OrlinVasilev and chlins Dec 12, 2024
@stonezdj stonezdj added the release-note/ignore-for-release Do not include PR or Issue for release notes label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore-for-release Do not include PR or Issue for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants