macOS: allow running unpacked game files from .app bundle resources #101125
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
reviewed
Jan 4, 2025
core/config/project_settings.cpp
Outdated
|
|
||
| if (!found) { | ||
| // Attempt to load project file from macOS .app bundle resources. | ||
| String bundle_resource_dir = OS::get_singleton()->get_bundle_resource_dir(); |
There was a problem hiding this comment.
get_bundle_resource_dir can return empty string is app is not bundled, so it should check if it's not empty. For consistency, I would also move it down to the part after // Try to use the filesystem for files, according to OS..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When releasing a Godot game for Linux or Windows, instead of distributing a .pck file containing your game alongside the engine executable, you can place the individual game files to be loaded in the same directory as the executable. I believe something similar is done by default on Android.
The benefit of doing it this way is that at least for a platform like Steam, updates to your game will come as patches to the individual files which in theory will be more efficient than patching a single monolithic pack file.
This PR enables loading the project file and assets from the Resources folder in macOS .app bundles just as .pck files are, for parity with Linux and Windows.