Implement @no_storage annotation
#101117
Open
Implement @no_storage annotation
#101117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synzorasize
changed the title
@no_storage annotation
Synzorasize
force-pushed
the
implement_2539
branch
2 times, most recently
from
37f2ae5 to
e015de2
Compare
dalexeev
reviewed
Jan 4, 2025
Synzorasize
force-pushed
the
implement_2539
branch
from
e015de2 to
fcce45d
Compare
Synzorasize
force-pushed
the
implement_2539
branch
3 times, most recently
from
7e6f03b to
866ce63
Compare
Synzorasize
force-pushed
the
implement_2539
branch
from
866ce63 to
99bbc63
Compare
|
Sorry for spamming the workflow runs, I didn't see where I could run the checks locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes godotengine/godot-proposals#2539. This adds a new export annotation,
@no_storage, that must go after an@exportannotation to be used. It will remove thePROPERTY_USAGE_STORAGEflag from the exported variable, allowing it to be editor-only.I used suggestions from the above issue and from related issues in this commit, including those by @dalexeev. Feel free to request changes. I wrote the documentation for
@no_storagebased on@exportand@export_storage, but it can possibly be improved.Due to a limitation of my implementation, I could not entirely preventEdit: I fixed this issue with @dalexeev's solution, so I removed that note. Also, since the documentation is listed alphabetically,@export_customfrom being used along with@no_storage, so I put it in a note in the documentation that it is not recommended to use them together.@no_storageappears separately from the other export annotations. It may be fine since it is a special one, but still something to note.