Add explicit error messages to Multimesh functions #101109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs easier to understand. Previously the RenderingServer errors filtered up to end users, but they are unclear and not helpful
clayjohn
added
enhancement
topic:core
cherrypick:4.3
rburing
reviewed
Jan 4, 2025
| @@ -249,39 +255,56 @@ void MultiMesh::set_physics_interpolation_quality(PhysicsInterpolationQuality p_ | |||
| } | |||
|
|
|||
| void MultiMesh::set_instance_transform(int p_instance, const Transform3D &p_transform) { | |||
| ERR_FAIL_INDEX_MSG(p_instance, instance_count, "Instance index out of bounds. Instance index must be a positive number that is less than `instance_count`."); | |||
There was a problem hiding this comment.
Should say non-negative rather than positive (to include zero).
JimmyCushnie
reviewed
Jan 4, 2025
| uint32_t stride = transform_format == TRANSFORM_2D ? 8 : 12; | ||
| stride += use_colors ? 4 : 0; | ||
| stride += use_custom_data ? 4 : 0; | ||
| ERR_FAIL_COND_MSG(stride * instance_count != p_buffer.size(), "Cannot set a buffer on a Multimesh that is a different size from the Multimeshes existing buffer."); |
There was a problem hiding this comment.
Suggested change
| ERR_FAIL_COND_MSG(stride * instance_count != p_buffer.size(), "Cannot set a buffer on a Multimesh that is a different size from the Multimeshes existing buffer."); | |
| ERR_FAIL_COND_MSG(stride * instance_count != p_buffer.size(), "Cannot set a buffer on a Multimesh that is a different size from the Multimesh's existing buffer."); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #100988
Previously the RenderingServer errors filtered up to end users, but they are unclear and not helpful. This PR adds explicit messages to make the errors easier to understand and to avoid even calling into the RenderingServer.