You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the SCIM standard both id and userName must be unique.
The current behaviour only rejects duplicate ids, and this PR fixes it.
A new test case has been added: test_user_create_duplicate_by_username, and run.
Results from https://scimvalidator.microsoft.com/ have been saved and replayed for local testing.
Checklist
Local tests pass (sudo poetry run python -m manage test authentik/sources/scim/tests/test_users.py)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
According to the SCIM standard both
idanduserNamemust be unique.The current behaviour only rejects duplicate
ids, and this PR fixes it.A new test case has been added:
test_user_create_duplicate_by_username, and run.Results from https://scimvalidator.microsoft.com/ have been saved and replayed for local testing.
Checklist
sudo poetry run python -m manage test authentik/sources/scim/tests/test_users.py)make lint-fix)