fix: NewRoute/NewBaseRoute to take engine not just OpeAPI for accepted content types

[dylanhitt]

Relates to #333

Somewhere along implementing support for different engines this was lost. This is a bit disruptive as it's changing the NewRoute/NewBaseRoute. The other option would be to place acceptedContentTypes on our OpenAPI struct I could go either way. We wouldn't be changing the NewRoute and NewBaseRoute API in the case of the later, but again we'd need to support yet another nested structure with it's own options. I think flattening in the Engine is OK, I guess 🤷.

So the options are

1. This PR. Just be fine with configuration occurring on the engine struct
2. Place acceptedContentTypes in the OpenAPI struct. We can could then do something like

func WithRequestContentType(consumes ...string) func(*Engine) {
	return func(e *Engine) { e.OpenAPI.acceptedContentTypes = consumes }
}

3. Place acceptedContentTypes in the OpenAPI struct. And expose a WithOpenAPIOptions. At this point we're nesting pretty deep...
4. This could exist on the OpenAPIConfig struct as well. Then engine would still need to be passed to the New*Route funcs.

Cheers

[EwenQuim]

But do we really need this? For future compatibility maybe?

[dylanhitt]

I figure we can just deprecate this function. You are just talking about the function right? Deprecating the Struct of BaseRoute would be a fairly large change which we'd probably want a separate PR for.

[EwenQuim]

No, I was talking about changing the *OpenAPI param to *engine

[dylanhitt]

Oh. It fixed the WithContentTypes option. I think the line you're missing is:

https://github.com/go-fuego/fuego/pull/334/files#diff-6b1e829598248403d0c671996c16c10f8a2d8db33f96b6db158654b78103dec4R31

see the AcceptedContentTypes: e.acceptedContentTypes,

[dylanhitt]

Hence my 4 questions where do we want to put acceptedContentTypes and how do we want to provide an option to configure it 😄

[dylanhitt]

Let me know if that clarifies things. I personally don't mind acceptedContentTypes existing on the Engine. At the very least I want avoid having to support a set of options for NewOpenAPI as we're getting to be pretty nested at that point.

So my preference is: 1 or 2