Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ORC in neonv8 machine definition #675

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

argilo
Copy link
Member

@argilo argilo commented Oct 22, 2023

I noticed that neonv8 kernels do not run in CI, nor do they run on my Raspberry Pi if liborc-0.4-dev is installed. It looks like this happens because VOLK chooses the neon_orc machine over the ORC-less neonv8 machine.

The neonv8 machine is the only one in machines.xml that lacks orc|; adding this corrects the problem, and VOLK then chooses the neonv8_orc machine and executes neonv8 kernels.

@argilo
Copy link
Member Author

argilo commented Oct 22, 2023

CI logs show that neonv8 kernels are now executing on aarch64.

The test failure is unrelated; it's due to #676.

Copy link
Contributor

@jdemel jdemel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdemel jdemel merged commit e853e9b into gnuradio:main Oct 23, 2023
31 of 32 checks passed
@argilo argilo deleted the neonv8-orc branch October 23, 2023 13:44
Alesha72003 pushed a commit to Alesha72003/volk that referenced this pull request May 15, 2024
Include ORC in neonv8 machine definition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants