Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare license switch #604

Merged
merged 1 commit into from
Jan 14, 2023
Merged

Conversation

jdemel
Copy link
Contributor

@jdemel jdemel commented Oct 9, 2022

So far, this is a draft.

This PR does multiple things

  • Removes GPL license files in favor of the new LGPL license files according to the new license that we use now.
  • Temporarily adds a script that changes the SPDX license identifiers in all files were it currently says "GPL v3 ...".
  • Makes sure that all reasonable files carry an SPDX license identifier. Restrictions apply to some file types, e.g. binary, auto-generated, orc and assembler files.

The intention of this PR is to make the switch as simple as possible. The only thing we would need to do is:

  • run the script switch_to_lgpl.py
  • remove the script (or move it to the scripts/licensing folder)
  • squash commits in this PR to ensure it is easy to find all license related work.

Closes #492
Closes #581

At the moment, I consider the issues #597, #598, and #601 blocking issues that should be fairly easy to resolve though. Also, #603 should be merged first as soon as it is ready.

Copy link
Contributor

@michaelld michaelld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that this PR is just draft for now, but LGTM ... great start! If we want to go ahead & merge this I'm OK with it. If there are more changes coming, please re-request my review

elif p.is_file():
files.append(p)
else:
print(f"What the fuck? == {p}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this!

@jdemel jdemel force-pushed the prepare-license-switch branch 2 times, most recently from d71c8b4 to 37a5c95 Compare January 14, 2023 16:06
@jdemel jdemel marked this pull request as ready for review January 14, 2023 16:06
@jdemel jdemel force-pushed the prepare-license-switch branch from 37a5c95 to b812382 Compare January 14, 2023 16:07
Wherever applicable files received an SPDX license identifier. Then,
this commit removes the GPL license files and consolidates all license
matters under the new LGPLv3+ license.

Signed-off-by: Johannes Demel <[email protected]>
@jdemel jdemel force-pushed the prepare-license-switch branch from b812382 to d732e3e Compare January 14, 2023 16:28
@jdemel jdemel merged commit 18a0a3e into gnuradio:main Jan 14, 2023
@jdemel jdemel deleted the prepare-license-switch branch January 14, 2023 17:02
Alesha72003 pushed a commit to Alesha72003/volk that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare and release VOLK 3.0 Relicense VOLK under LGPL
2 participants