Cleanup Public header files and bindings #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move public include files to CRLF EoL sequence wor Windows compat, Redo binding with pybind11 files Signed-off-by: Cyrille Morin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the old
./include/bokehguipublic header files to the new gr3.10+./include/gnuradio/bokehguifolder for better gr_modtool compatibility.Move public include files to CRLF EoL sequence instead of just LF. This should enable Windows users to build without having to rebind headers to pybind11 manually.
Redo binding with pybind11 files for the newly modified headers.