C#: params modifier on collection types. #18329
Conversation
michaelnebel
force-pushed
the
csharp/params
branch
from
78817bd to
ecced67
Compare
…e the test reports indexer access and calls to Add for list and collection creations).
…s to allow ParamsCollectionType.
michaelnebel
force-pushed
the
csharp/params
branch
from
ecced67 to
f4539f7
Compare
Copilot
AI
left a comment
Copilot
AI
left a comment
There was a problem hiding this comment.
Copilot reviewed 13 out of 30 changed files in this pull request and generated 2 comments.
Files not reviewed (17)
- csharp/ql/lib/semmle/code/csharp/Callable.qll: Language not supported
- csharp/ql/lib/semmle/code/csharp/Variable.qll: Language not supported
- csharp/ql/lib/semmle/code/csharp/commons/Collections.qll: Language not supported
- csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowPrivate.qll: Language not supported
- csharp/ql/lib/semmle/code/csharp/dispatch/Dispatch.qll: Language not supported
- csharp/ql/lib/semmle/code/csharp/frameworks/Format.qll: Language not supported
- csharp/ql/lib/semmle/code/csharp/frameworks/System.qll: Language not supported
- csharp/ql/lib/semmle/code/csharp/frameworks/system/collections/Generic.qll: Language not supported
- csharp/ql/test/library-tests/arguments/argumentByName.expected: Language not supported
- csharp/ql/test/library-tests/arguments/argumentByParameter.expected: Language not supported
- csharp/ql/test/library-tests/arguments/argumentByParameter.ql: Language not supported
- csharp/ql/test/library-tests/arguments/argumentName.expected: Language not supported
- csharp/ql/test/library-tests/arguments/argumentType.expected: Language not supported
- csharp/ql/test/library-tests/arguments/parameterGetArguments.expected: Language not supported
- csharp/ql/test/library-tests/arguments/parameterGetArguments.ql: Language not supported
- csharp/ql/test/library-tests/dispatch/CallContext.expected: Language not supported
- csharp/ql/test/library-tests/dispatch/GetADynamicTarget.expected: Language not supported
Tip: Leave feedback on Copilot's review comments with the 👎 and 👍 buttons to help improve review quality. Learn more
| { | ||
| f10(0, 1, 2); | ||
| f10(0, [1, 2]); | ||
| f10(args: 1, o: 0); |
There was a problem hiding this comment.
The params modifier expects a List, but 1 is an int. It should be f10(args: new List { 1 }, o: 0);
| f10(args: 1, o: 0); | |
| f10(args: new List<int> { 1 }, o: 0); |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
| SinkCollectionParams(new A()); // flow | ||
| SinkCollectionParams(null, new A()); // flow | ||
| SinkCollectionParams(null, new A(), null); // flow | ||
| SinkCollectionParams([new A()]); // flow |
There was a problem hiding this comment.
The use of square brackets '[]' for collection initialization is incorrect in C#. It should be replaced with curly braces '{}'.
| SinkCollectionParams([new A()]); // flow | |
| SinkCollectionParams(new A[] { new A() }); // flow |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
| abstract Type getElementType(); | ||
| } | ||
|
|
||
| private class AddArrayType extends ParamsCollectionTypeImpl instanceof ArrayType { |
There was a problem hiding this comment.
Why is this class named AddArrayType? An alternative would be ParamsArrayType.
| override Type getElementType() { result = ArrayType.super.getElementType() } | ||
| } | ||
|
|
||
| private class AddCollectionTypes extends ParamsCollectionTypeImpl { |
There was a problem hiding this comment.
An alternative name could be ParamsConstructedCollectionTypes?
In this PR we make the relevant updates to the CodeQL library to support collection like types for
paramsparameters. The extractor worked out of the box for extracting these types.The feature is described here: https://learn.microsoft.com/en-us/dotnet/csharp/whats-new/csharp-13#params-collections