Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable uploading debug artifacts #2712

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

angelapwen
Copy link
Contributor

@angelapwen angelapwen commented Jan 22, 2025

Existing PR checks for debug artifacts will be failing and this is expected.

I have temporarily removed them from branch protection rules. We should re-add them when we restore functionality.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@Copilot Copilot bot review requested due to automatic review settings January 22, 2025 18:35
@angelapwen angelapwen requested a review from a team as a code owner January 22, 2025 18:35

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

@angelapwen angelapwen force-pushed the angelapwen/stop-debug-artifacts branch from 4c26822 to 519de26 Compare January 22, 2025 18:35
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming that eslint doesn't complain about unreachable code.

@angelapwen angelapwen enabled auto-merge January 22, 2025 18:39
@angelapwen angelapwen merged commit 23ec3af into main Jan 22, 2025
256 checks passed
@angelapwen angelapwen deleted the angelapwen/stop-debug-artifacts branch January 22, 2025 18:53
@github-actions github-actions bot mentioned this pull request Jan 22, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants