Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gfx to 0a201d1c406b5119ec11068293a40e50ec0be4c8 #1236

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

Aaron1011
Copy link
Contributor

Connections
wgpu issue: #246
GFX PR: gfx-rs/gfx#3653
Underlying libloading issue: nagisa/rust_libloading#41

Description

Pulls in gfx-rs/gfx#3653,
which fixes a segfault when using wgpu from a non-main thread.

Testing

The example in #246 should run successfully. I'm not certain how to add an integration test to the repository.

Fixes gfx-rs#246

Pulls in gfx-rs/gfx#3653,
which fixes a segfault when using wgpu from a non-main thread.
Copy link
Contributor

@monocodus monocodus bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an autogenerated code review.

Checker summary (by rust_clippy):
The tool has found 94 warnings, 0 errors.

Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 26, 2021

@bors bors bot merged commit 39aa01d into gfx-rs:master Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants