Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ON HOLD] - Update syncthing to version v1.29.0 #2029

Closed
wants to merge 1 commit into from

Conversation

nmfretz
Copy link
Contributor

@nmfretz nmfretz commented Jan 8, 2025

🤖 This is an automated pull request to update syncthing to version v1.29.0. This PR must be reviewed and tested before merging.

Copy link

github-actions bot commented Jan 8, 2025

🎉   Linting finished with no errors or warnings   🎉

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
ℹ️ syncthing/docker-compose.yml External port mapping "22000:22000/tcp":
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
ℹ️ syncthing/docker-compose.yml External port mapping "22000:22000/udp":
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).

Legend

Symbol Description
Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.

@nmfretz
Copy link
Contributor Author

nmfretz commented Jan 8, 2025

🤖 This is an automated summary of installation tests for syncthing:

  • ✅ App successfully installed in umbrel-dev instance
  • ✅ App successfully listed in umbrel.yaml
  • ✅ App UI successfully returns a 200 status code

This PR must still be reviewed and tested before merging.

@nmfretz
Copy link
Contributor Author

nmfretz commented Jan 8, 2025

Placing this PR on hold for now:

image

@nmfretz nmfretz changed the title Update syncthing to version v1.29.0 [ON HOLD] - Update syncthing to version v1.29.0 Jan 8, 2025
@nmfretz nmfretz marked this pull request as draft January 8, 2025 23:22
@al-lac
Copy link
Contributor

al-lac commented Jan 10, 2025

@nmfretz I looked into the new update 1.29.1, seems to work fine, see #2043

Looks like the automation did not update the sha256 in this PR.

@nmfretz
Copy link
Contributor Author

nmfretz commented Jan 12, 2025

Looks like the automation did not update the sha256 in this PR.

haha, amazing. Thanks for spotting that @al-lac!

@nmfretz nmfretz closed this Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants