Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update invoice-ninja to version v5.11.7 #2003

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nmfretz
Copy link
Contributor

@nmfretz nmfretz commented Jan 2, 2025

🤖 This is an automated pull request to update invoice-ninja to version v5.11.7. This PR must be reviewed and tested before merging.

@nmfretz
Copy link
Contributor Author

nmfretz commented Jan 2, 2025

🤖 This is an automated summary of installation tests for invoice-ninja:

  • ✅ App successfully installed in umbrel-dev instance
  • ❌ App not listed in umbrel.yaml
  • ⚠️ App UI accessibility was not tested

This PR must still be reviewed and tested before merging.

Copy link

github-actions bot commented Jan 2, 2025

🎉   Linting finished with no errors or warnings   🎉

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
ℹ️ invoice-ninja/docker-compose.yml Potentially using unsafe user in service "nginx":
The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.

Legend

Symbol Description
Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.

@nmfretz
Copy link
Contributor Author

nmfretz commented Jan 2, 2025

From testing it appears that we need to upgrade the mariadb image as of invoice-ninja v5.11.1 (first version where we see the following error):

In Process.php line 270:
                                                                               
  The command "mysql  --user="${:LARAVEL_LOAD_USER}" --password="${:LARAVEL_L  
  OAD_PASSWORD}" --host="${:LARAVEL_LOAD_HOST}" --port="${:LARAVEL_LOAD_PORT}  
  " --database="${:LARAVEL_LOAD_DATABASE}" < "${:LARAVEL_LOAD_PATH}"" failed.  
                                                                               
  Exit Code: 1(General error)                                                  
                                                                               
  Working directory: /var/www/app                                              
                                                                               
  Output:                                                                      
  ================                                                             
                                                                               
                                                                               
  Error Output:                                                                
  ================                                                             
  mysql: Deprecated program name. It will be removed in a future release, use  
   '/usr/bin/mariadb' instead                                                  
  ERROR 2026 (HY000): TLS/SSL error: SSL is required, but the server does not  
   support it                      

Using mariadb:latest resolves this issue.

TODO: look into safely upgrading mariadb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant