Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Elements Core to v23.2.4 & PeerSwap to v4rc2 #1926

Merged
merged 6 commits into from
Dec 31, 2024
Merged

Update Elements Core to v23.2.4 & PeerSwap to v4rc2 #1926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f5957cd
Update Elements Core to v23.2.4
Impa10r Dec 14, 2024
fc43137
PeerSwap v1.7.4
Impa10r Dec 15, 2024
7dc4c7b
Merge branch 'getumbrel:master' into master
Impa10r Dec 28, 2024
2f1e413
Push PSWeb to v1.7.5
Impa10r Dec 28, 2024
9aa4164
Fix linter
Impa10r Dec 28, 2024
ad2814a
Fix linter
Impa10r Dec 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion elements/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,11 @@
APP_PORT: 8080

node:
image: ghcr.io/vulpemventures/elements:23.2.1@sha256:8bd481aaa0f055b59a8c0bb7e56b0f1d1a55143acbb0d07465778538730c41b3
image: ghcr.io/vulpemventures/elements:23.2.4@sha256:f4bb9af7f2278e6b6a7a6160f5f17eec28e85a2bf47ebbdc96d0e64caa582d16
user: "1000:1000"
restart: on-failure
stop_grace_period: 1m
ports:

Check notice on line 14 in elements/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

External port mapping "$APP_ELEMENTS_NODE_RPC_PORT:$APP_ELEMENTS_NODE_RPC_PORT" 

Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).

Check notice on line 14 in elements/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

External port mapping "$APP_ELEMENTS_NODE_P2P_PORT:$APP_ELEMENTS_NODE_P2P_PORT" 

Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
- $APP_ELEMENTS_NODE_RPC_PORT:$APP_ELEMENTS_NODE_RPC_PORT # JSONRPC
- $APP_ELEMENTS_NODE_P2P_PORT:$APP_ELEMENTS_NODE_P2P_PORT # P2P PORT
volumes:
Expand Down Expand Up @@ -39,9 +40,12 @@
- -port=$APP_ELEMENTS_NODE_P2P_PORT
- -blockfilterindex=1
- -peerblockfilters=1
# Enable creating discounted CT on mainnet
- -creatediscountct=1

web:
image: ghcr.io/tiero/elements-web:v0.0.3@sha256:b80dc0df2a4693668a97b874aad6d0a8d3239d03f4d05b4342600166934d0b87
user: "1000:1000"
depends_on:
- node
restart: on-failure
Expand All @@ -59,7 +63,7 @@
image: getumbrel/tor:0.4.7.8@sha256:2ace83f22501f58857fa9b403009f595137fa2e7986c4fda79d82a8119072b6a
user: "1000:1000"
restart: on-failure
volumes:

Check notice on line 66 in elements/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Mounted file/directory "/elements/torrc" doesn't exist 

The volume "${APP_DATA_DIR}/torrc:/etc/tor/torrc:ro" tries to mount the file/directory "/elements/torrc", but it is not present. This can lead to permission errors!
- ${APP_DATA_DIR}/torrc:/etc/tor/torrc:ro
- ${TOR_DATA_DIR}:/data
environment:
Expand Down
11 changes: 5 additions & 6 deletions elements/umbrel-app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ manifestVersion: 1.1
id: elements
category: bitcoin
name: Elements Core
version: "23.2.1"
version: "23.2.4"
tagline: Liquid Network full node
description: >-
Elements is an open source full node implementation to run the Liquid
Expand All @@ -13,13 +13,12 @@ description: >-

This app has the potential to use up to 6GB of RAM. It's important to confirm that your device meets the necessary hardware requirements before installing and running the app.
releaseNotes: >-
This release updates elements from version 22.1.1 to 23.2.1, and features various bug fixes and improvements such as:
This release updates elements from version 23.2.1 to 23.2.4, and features various bug fixes and improvements such as:


- Brings Elements up to date with Bitcoin Core version 23.2

- Fixes a problem in the getnewaddress rpc: getnewaddress will now return an unblinded bech32 address even when -blindedaddresses=1 in config
- Enables discounted CT transactions

- Brings Elements up to date with Bitcoin Core version 28

- In contrast to Bitcoin, Elements is not changing the default wallet format from legacy to descriptors, this is because many things (like peg-ins and peg-outs) still work only on legacy wallets.


Expand Down
7 changes: 6 additions & 1 deletion peerswap/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ services:
APP_PORT: 1984

web:
image: ghcr.io/impa10r/peerswap-web:v1.6.9@sha256:a925714945527bae8d792c47f83ed13048f192e3613b06e15b9af4bd60cfe504
image: ghcr.io/impa10r/peerswap-web:v1.7.5@sha256:9ce9a183c5b7f689ba036b4736a0eb4737978208b1afb4f1e8981860a5036cb4
user: "1000:1000"
restart: on-failure
stop_grace_period: 1m
Expand All @@ -25,6 +25,11 @@ services:
ELEMENTS_WALLET: peerswap
ELEMENTS_FOLDER: /home/elements/.elements
ELEMENTS_FOLDER_MAPPED: /home/peerswap/.elements
# Bitcoin RPC
BITCOIN_HOST: $APP_BITCOIN_NODE_IP
BITCOIN_PORT: $APP_BITCOIN_RPC_PORT
BITCOIN_USER: $APP_BITCOIN_RPC_USER
BITCOIN_PASS: $APP_BITCOIN_RPC_PASS
volumes:
- ${APP_DATA_DIR}/data:/home/peerswap/.peerswap
- ${APP_LIGHTNING_NODE_DATA_DIR}:/home/peerswap/.lnd:ro
Expand Down
8 changes: 6 additions & 2 deletions peerswap/umbrel-app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ manifestVersion: 1
id: peerswap
category: bitcoin
name: PeerSwap
version: "1.6.9"
version: "1.7.5"
tagline: Balance your lightning channels with Liquid BTC
description: PeerSwap enables Lightning Network nodes to balance their channels by facilitating atomic swaps with direct peers. PeerSwap enhances decentralization of the Lightning Network by enabling all nodes to be their own swap provider. No centralized coordinator, no 3rd party rent collector, and lowest cost channel balancing means small nodes can better compete with large nodes. Includes channel AutoFees, Liquid Peg-in and BTC send with coin select + fee bump functionality.
developer: PeerSwap Project
Expand All @@ -21,4 +21,8 @@ path: ""
submitter: Impa10r
submission: https://github.com/getumbrel/umbrel-apps/pull/932
releaseNotes: >-
Bug fixes and improvements. See full changelog here: https://github.com/Impa10r/peerswap-web/blob/main/CHANGELOG.md
This release upgrades PeerSwap to v4rc1 and enables Liquid CT fee discounts on mainnet.

Warning: only peers who upgraded to v4 will be visible in Peer List.

Full changelog: https://github.com/Impa10r/peerswap-web/blob/main/CHANGELOG.md
Loading