fixes here and there

getsentry · Jan 8, 2025 · e1e5eae · e1e5eae
1 parent 3d2be5d
commit e1e5eae
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/tests/web/rpc/v1/test_endpoint_trace_item_attribute_names.py b/tests/web/rpc/v1/test_endpoint_trace_item_attribute_names.py
@@ -246,6 +246,7 @@ def test_page_token_offset_filter(self) -> None:
             )
             res = EndpointTraceItemAttributeNames().execute(req)
             page_token = res.page_token
+            assert isinstance(page_token, PageToken)
             assert res.attributes == expected_attributes[:at_a_time]
             expected_attributes = expected_attributes[at_a_time:]
             done += at_a_time

diff --git a/tests/web/rpc/v1/test_trace_item_attribute_values_v1.py b/tests/web/rpc/v1/test_trace_item_attribute_values_v1.py
@@ -7,7 +7,7 @@
 from sentry_protos.snuba.v1.endpoint_trace_item_attributes_pb2 import (
     TraceItemAttributeValuesRequest,
 )
-from sentry_protos.snuba.v1.request_common_pb2 import RequestMeta
+from sentry_protos.snuba.v1.request_common_pb2 import PageToken, RequestMeta
 from sentry_protos.snuba.v1.trace_item_attribute_pb2 import AttributeKey
 
 from snuba.datasets.storages.factory import get_storage
@@ -145,7 +145,7 @@ def test_page_token(self, setup_teardown: Any) -> None:
             done += at_a_time
         assert expected_values == []
 
-    def test_filter_offset_is_not_implemented_right_now(self) -> None:
+    def test_page_token_filter_offset(self) -> None:
         expected_values = [
             "blah",
             "derpderp",
@@ -170,6 +170,7 @@ def test_filter_offset_is_not_implemented_right_now(self) -> None:
             )
             res = AttributeValuesRequest().execute(req)
             page_token = res.page_token
+            assert isinstance(page_token, PageToken)
             assert res.values == expected_values[:at_a_time]
             expected_values = expected_values[at_a_time:]
             done += at_a_time