feat(widget-builder): Validate widget before saving #82807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
narsaynorath
approved these changes
Jan 3, 2025
| await validateWidget(api, organization.slug, widget); | ||
| onSave({index: Number(widgetIndex), widget}); | ||
| } catch (error) { | ||
| addErrorMessage('Unable to save widget'); |
There was a problem hiding this comment.
Suggested change
| addErrorMessage('Unable to save widget'); | |
| addErrorMessage(t('Unable to save widget')); |
Bundle ReportChanges will increase total bundle size by 159.4kB (0.5%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're reusing the
validateWidgetfunction that is being used in the current widget builder. I've added that validation check to the save button so it will validate before carrying out the saving and closing process. When the widget is not valid it displays the message as such:In future PRs I will implement field highlighting for the fields that are causing validation errors.
Related to #81729