feat: Skip large diffs when generating context for the LLM #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgilpin
reviewed
Jan 23, 2025
| content: diffContent | ||
| .filter(Boolean) | ||
| .map((diff) => processPatchset(diff)) | ||
| .join('\n\n'), |
There was a problem hiding this comment.
I have been looking into this type of limiting as well, and one of the issues I see is that getDiffLog returns, as the name suggests, git log output not git diff output. So, splitting this output would seem to be more naturally done on the commit <sha> (author) rather than on the diff --git line.
WDYT?
commit 5f7fed0d7fab55e9b2cdc6cddbebd9644bca416c
Author: Kevin Gilpin <[email protected]>
Date: Thu Jan 23 09:49:53 2025 -0500
refactor: Remove unused code
Locating the git repository - can't find any references to this any more
diff --git a/packages/cli/src/lib/git.ts b/packages/cli/src/lib/git.ts
index 5bd8b0a03..139b10eca 100644
--- a/packages/cli/src/lib/git.ts
+++ b/packages/cli/src/lib/git.ts
There was a problem hiding this comment.
In other words, maybe it would be better / easier if getDiffLog and getWorkingDiff returned an output that had some structure (at least an array of chunks?) rather than just a string that the caller then has to figure out how to split.
There was a problem hiding this comment.
Good point, I've actually noticed this too and fixed it in the amend below :)
dividedmind
force-pushed
the
fix/skip-large-diffs
branch
from
b9385af to
abaf705
Compare
dividedmind
force-pushed
the
fix/skip-large-diffs
branch
from
abaf705 to
1bfa817
Compare
dividedmind
force-pushed
the
fix/skip-large-diffs
branch
from
1bfa817 to
0d09b7d
Compare
dustinbyrne
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This skips diffs larger than 5000 characters when generating input for
@welcomeand@review. Large diffs are replaced with a message, for exampleFixes #2173