Improve sequence diagram load time #1412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Surprisingly, this improves sequence diagram load time by about 15%
This improves the load time of sequence diagrams by about 46%
ahtrotta
force-pushed
the
feat/improve-sequence-diagram-load-time
branch
from
1f0ac37 to
3f5d737
Compare
This reduces the number of times we need to parse the SQL, which is expensive, and improves sequence diagram load times by ~24%
dustinbyrne
reviewed
Oct 6, 2023
| @@ -1,3 +1,4 @@ | |||
| /* eslint-disable */ | |||
There was a problem hiding this comment.
This looks like it's been removed upstream already, but please make sure it doesn't make it to main :-)
|
These changes are all in different PRs now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1411
PRs #1416 and #1418 will need to be merged and released before this one.
buildDiagramtwice when loading sequence diagram (~46% improvement)