Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing ~ to $HOME in instructions for location of Java agent #1359

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brikelly
Copy link
Contributor

@brikelly brikelly commented Sep 7, 2023

Raised by a user: using ~ causes problems with IntelliJ, so we will use $HOME instead.

@brikelly brikelly self-assigned this Sep 7, 2023
@brikelly brikelly requested a review from ahtrotta September 7, 2023 20:41
@dustinbyrne dustinbyrne self-requested a review September 8, 2023 14:08
@ahtrotta
Copy link
Contributor

ahtrotta commented Sep 8, 2023

I'm assuming that the user was trying to modify their Run Config to add the VM argument themselves, right? If I modify the Run Config for PetClinicApplication.java to use $HOME:

image

I get this error:

image

Which is essentially the same error that I get when I use ~ instead of $HOME:

image

So either I'm doing something wrong (very possible!), or this doesn't fix the issue.

@kgilpin
Copy link
Contributor

kgilpin commented Sep 8, 2023 via email

@brikelly
Copy link
Contributor Author

brikelly commented Sep 8, 2023

Maybe a better intent is to convey that they should expand $HOME and use that path explicitly. I guess we can expand it for them and just show the exact full path in these instructions, wdyt?

@apotterri apotterri self-requested a review September 11, 2023 08:52
@brikelly brikelly removed their assignment Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants