Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix message when missing optional dependencies in elevation module #1250

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

gboeing
Copy link
Owner

@gboeing gboeing commented Dec 10, 2024

This PR fixes the bug where the elevation module would raise an ImportError claiming that rasterio wasn't installed when it was, but rio-vrt actually was not installed. Now the ImportError names the correct missing optional dependency.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.44%. Comparing base (10a1686) to head (8eadb2d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1250   +/-   ##
=======================================
  Coverage   98.44%   98.44%           
=======================================
  Files          24       24           
  Lines        2383     2384    +1     
=======================================
+ Hits         2346     2347    +1     
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gboeing gboeing merged commit bffcba2 into main Dec 10, 2024
10 checks passed
@gboeing gboeing deleted the imports branch December 10, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant