Update RGBDS to 0.9.0

[SelvinPL]

Related to #60

[SelvinPL]

Wait ... this build create rgbfix rgblink without .wasm extension ...
so it's not working I need to fix it
Nevermind, it's working fine
https://selvin.pl/rgbds-live/?asm=-version

[SelvinPL]

patch worked without updated indexes but now if you patch with
/rgbds-live/rgbds$ patch -p1 < ../patches/rgbds.patch
then executing
/rgbds-live/rgbds$ git diff --patch > ../patches/rgbds.patch
will will not modifiy ../patches/rgbds.patch while without c959314 it would
NOTE FOR FUTURE rgbds version commits:

• do not forget to update documentation link
• /rgbds-live/rgbds$ git diff --patch > ../patches/rgbds.patch should be matadory for fixing indexes even if patch works without

this is filnal commit, sorry for posting this in 3 pices

[SelvinPL]

Wait ... this build create rgbfix rgblink without .wasm extension ... so it's not working I need to fix it

it was because (in build.sh)
test -f rgbds/rgbasm.wasm || ./build-rgbds.sh
when I didn't fully build before

[Rangi42]

Thank you for taking care of this! 😎

[SelvinPL]

Thank you for taking care of this! 😎

no problem ... you are doing great job with rgbds itself :D

[SelvinPL]

also what about such solution?
gbdev/rgbds#1604

[SelvinPL]

additionally i've remove modifing symbol.hpp file and moved decalration of Symbol *sym_AddSecret(); directly to parser.y
EDIT: in fact we could move all code to parser.y

[SelvinPL]

additionally i've remove modifing symbol.hpp file and moved decalration of Symbol *sym_AddSecret(); directly to parser.y EDIT: in fact we could move all code to parser.y

no, we can't as createSymbol and updateSymbolFilename are private(static) to symbol.cpp

[Rangi42]

https://selvin.pl/rgbds-live/?asm=-version currently logs:

Running: rgbasm main.asm -o output.o -Wall -version
rgbasm v0.9.0-dirty
Build failed

And Step/Run/etc do not work.

This should be building a "v0.9.0", not a "-dirty" version. Also please deploy the latest commit in this PR branch to there, to confirm it works?

[SelvinPL]

https://selvin.pl/rgbds-live/?asm=-version currently logs:

Running: rgbasm main.asm -o output.o -Wall -version
rgbasm v0.9.0-dirty
Build failed

this is greater problem ... without -version its working fine ... i think it is because how output is parsed
(and should be fixed as other issue)

And Step/Run/etc do not work.

This should be building a "v0.9.0", not a "-dirty" version. Also please deploy the latest commit in this PR branch to there, to confirm it works?

I belive that dirty part comes from the fact that source was pached and don't know how to avoid this

And yes, this is build from the last commit

[Rangi42]

without -version its working fine ... i think it is because how output is parsed (and should be fixed as other issue)

I belive that dirty part comes from the fact that source was pached and don't know how to avoid this

And yes, this is build from the last commit

Okay, thanks, I see now. --version already prints "dirty" and breaks prod as well.

[Rangi42]

LGTM! 👍

[SelvinPL]

https://selvin.pl/rgbds-live/?asm=-version currently logs:

Running: rgbasm main.asm -o output.o -Wall -version
rgbasm v0.9.0-dirty
Build failed

Check: https://gbdev.io/rgbds-live/?asm=-version

maybe version is written to stderr? or maybe rgbds doesn't compile with -version switch