Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery dependency removed #37

Merged
merged 6 commits into from
Mar 7, 2018
Merged

Conversation

danagle
Copy link

@danagle danagle commented Mar 7, 2018

#32 In addition to jQuery, I also removed the lodash package - debounce and omit were the only methods of the library being used. The lodash.debounce and lodash.omit packages have been added as dependencies.

I also tidied up the imports to keep the code cleaner.

There are no tests to verify that I haven't broken anything but the browser console window didn't blow up if that's of any comfort to you!

@gazpachu
Copy link
Owner

gazpachu commented Mar 7, 2018

Nice work @danagle. Many thanks for your help and initiative :-)

@gazpachu gazpachu merged commit fe1d849 into gazpachu:development Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants