Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow test and history for SC cell cycle regression tutorial #5640

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

pavanvidem
Copy link
Member

First version WF test of this tutorial

@pavanvidem pavanvidem requested a review from a team as a code owner December 13, 2024 14:47
@bgruening
Copy link
Member

@pavanvidem I think if you rename the workflow, you need to add a redirect. To the other PRs as well.

e.g.

maybe?

@shiltemann
Copy link
Member

@bgruening @pavanvidem In this case it is a bit more complicated, since the workflow html page is created at build-time, so no good place to put the redirect_from directive currently.

If possible, I would simply avoid renaming the workflow file (the title of the workflow can always be updated of course). Or would this lead to problems for you @pavanvidem?

long-term I will think about how to best handle these cases, but for now probably easiest to just keep the original file names

@pavanvidem
Copy link
Member Author

@shiltemann is that what you meant?

@pavanvidem
Copy link
Member Author

sorry, I renamed a wrong file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you need to rename this back to main_workflow.ga?

@shiltemann shiltemann merged commit 0aef9d9 into galaxyproject:main Jan 14, 2025
3 checks passed
@shiltemann
Copy link
Member

Thanks @pavanvidem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants