-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add bedrecord/interval converters #27
Conversation
931d569
to
9808c99
Compare
I ran into circular imports when the converters were declared on I have a slight preference for putting them on |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
==========================================
+ Coverage 91.41% 91.79% +0.38%
==========================================
Files 7 8 +1
Lines 489 524 +35
Branches 86 92 +6
==========================================
+ Hits 447 481 +34
Misses 26 26
- Partials 16 17 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor fixups that I trust you can make. Thank-you!!!
@msto looks good to me based on your comments! |
@nh13 Minor changes to address the circular import and standardize on lmk if it still lgty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you just try the one suggestion, and if that doesn't work, ship it?
for posterity without importing
|
🙏
Let me know if you'd like equivalent methods added to
Interval