Introduce JAILED_DATASET option to poudriere.conf #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option allows passing a temporary ZFS dataset into the jail along with full control over it from within the jail. Sponsored by: Future Crew, LLC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for the change:
We at $WORK are using Poudriere as a part of the CI process. For a selected set of ports we define
WITH_TESTING_PORTS, which makes thetesttarget a part of the pipeline. It works quite well for many of ports we're using.However, one of the projects we've developed requires creating a ZFS dataset as part of its tests. The #1175 PR made it possible for
zfscommand to run, but no datasets or pools are visible from within the jail. This follow-up change passes through a throw-away ZFS dataset into the jail and gives full access to it.I understand that the feature is quite niche, but it doesn't add much complexity to the code, so I hope it will be accepted.