Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slider): fix slider validation layout shift #4

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

HELWATANY
Copy link
Contributor

  • 🐛 _slider.mdx: Set fixed width for the slider container.
  • 🐛 _slider.mdx: Set a minimum height and always display the error container.

Closes: #3

- 🐛 `_slider.mdx`: Set fixed width for the slider container.
- 🐛 `_slider.mdx`: Set a minimum height and always display the error container.

Closes: formwerkjs#3
Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for formwerk-docs ready!

Name Link
🔨 Latest commit fd81a7d
🔍 Latest deploy log https://app.netlify.com/sites/formwerk-docs/deploys/6774090b55503100080a39d7
😎 Deploy Preview https://deploy-preview-4--formwerk-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@logaretm logaretm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright, since these are examples that are meant to be followed by other people, we need to be extra careful about which styles/markup we add.

src/content/docs/guides/fields/_partials/_slider.mdx Outdated Show resolved Hide resolved
- 🐛 `_slider.mdx`: Remove the inner error message container
@HELWATANY HELWATANY requested a review from logaretm December 31, 2024 15:09
Copy link
Member

@logaretm logaretm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, many thanks!

@logaretm logaretm merged commit e5861ee into formwerkjs:main Dec 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving The Slider On Slider Validation Demo Cause Layout Shift
2 participants