Add guard in examples/*/Makefile to check that common.mk was actually found successfully.
#842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ally found successfully. Details: - If the examples are built out-of-tree then `BLIS_INSTALL_PATH` needs to be set to find the header, library, and build system files. Also, if the examples are attempted to be built before configuring blis then `common.mk` will be missing. - Current behavior silently ignores the failed import of `common.mk` which causes various difficult-to-diagnose problems.
Details: - When building examples out-of-tree (or potentially other external code using `common.mk`), `DIST_PATH` will not be set and so `common.mk` will not be able to locate `build/detect/android/bionic.h`, causing a compiler error in some cases. - This has been fixed by including the contents of `bionic.h` in the shell statement executing the compiler check. - Fixes #840.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
BLIS_INSTALL_PATHneeds to be set to find the header, library, and build system files. Also, if the examples are attempted to be built before configuring blis thencommon.mkwill be missing.common.mkwhich causes various difficult-to-diagnose problems.