Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: separate alarm emote from face animations #901

Merged
merged 1 commit into from
Jan 15, 2024
Merged

feat: separate alarm emote from face animations #901

merged 1 commit into from
Jan 15, 2024

Conversation

nelson137
Copy link
Contributor

@nelson137 nelson137 commented Jan 14, 2024 •
edited
Loading

Changes

  • Remove the alarm exclamation point from player face skins
  • Create a new player asset type (assets/player/emotes/alarm.emote.yaml)
    • The emote sprite is the same size as the face sprite and has the same offset. This made it easy to make sure it's in the same place relative to the player, but it can be shrunk to just the emote region if necessary.

zicklag
zicklag approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@zicklag zicklag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@zicklag zicklag added this pull request to the merge queue Jan 15, 2024
Merged via the queue into fishfolk:main with commit 6350789 Jan 15, 2024
9 checks passed
@nelson137 nelson137 deleted the isolate-alarm-emote branch January 15, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zicklag zicklag zicklag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split Face Animation From Exclamation Mark Animation
2 participants
@nelson137 @zicklag