feat: play sound on player death #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @elliay! I tested this and seems to be working well. A bit of feedback - it feels like there is a slight delay from after fish dies and sound is played, isn't huge, but wondering if can trim off slightly more of the lead time in sound? |
|
Trimmed the sound! What are your thoughts on it now? |
|
That's great - thanks! |
MaxCWhitehead
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a glug sound when player dies to give additional audio feedback. Here is the audio used: https://freesound.org/people/brittmosel/sounds/529300/
This resolves #986.