Add c_str method to string to match std::string

[opera-aberglund]

For reference: https://cplusplus.com/reference/string/string/c_str/

Just a convenience method, but it's one I used in the std lib and it was a hassle to remove every call to it when I switched to Cista strings.

[felixguendling]

The string.h string is not \0 terminated. So c_str() is very misleading here.

I propose to add .c_str() to the cista::cstring:
https://github.com/felixguendling/cista/blob/master/include/cista/containers/cstring.h

[opera-aberglund]

The string.h string is not \0 terminated. So c_str() is very misleading here.

I propose to add .c_str() to the cista::cstring: https://github.com/felixguendling/cista/blob/master/include/cista/containers/cstring.h

Ah you're right. Let me fix it.

[felixguendling]

If you want to mirror the standard, it seems it's always const.

https://en.cppreference.com/w/cpp/string/basic_string/c_str

Only .data() has a non-const overload.

https://en.cppreference.com/w/cpp/string/basic_string/data

[opera-aberglund]

If you want to mirror the standard, it seems it's always const.

https://en.cppreference.com/w/cpp/string/basic_string/c_str

Only .data() has a non-const overload.

https://en.cppreference.com/w/cpp/string/basic_string/data

Right right.. I though it was just an alias for .data(), but then perhaps it makes even more sense to have the c_str() method since it's guaranteed to be immutable.

[felixguendling]

Thanks! :)