Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving to llama.cpp server #111

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

jpodivin
Copy link
Collaborator

@jpodivin jpodivin commented Jan 17, 2025

Should address: #108

@jpodivin jpodivin requested a review from TomasTomecek January 17, 2025 10:36
@jpodivin jpodivin force-pushed the newserver branch 2 times, most recently from de8f2eb to 6b9af1c Compare January 17, 2025 11:07
Copy link
Collaborator

@TomasTomecek TomasTomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work, will deploy it on Mon and will also set up the GHA for image building

.env Show resolved Hide resolved
.env Show resolved Hide resolved
Containerfile.cuda Outdated Show resolved Hide resolved
* configuration is now almost entirely withing the .env file
* server is being build as part of container image
* llama.cpp source is selected by tag
* parallel execution enabled
* removed separate llama_cpp_server config

Signed-off-by: Jiri Podivin <[email protected]>
git checkout $LLAMACPP_VER && \
cmake -B build && \
cmake --build build --config Release -j 4 -t llama-server && \
mv ./build/bin/llama-server /bin/llama-server
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be /usr/bin/ ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's just link to /usr/bin anyway, and both are in path so it doesn't make any difference.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. But since the merge, we should use the correct path. And that is /usr/bin
https://discussion.fedoraproject.org/t/f40-change-proposal-unify-usr-bin-and-usr-sbin-system-wide/99853

@TomasTomecek
Copy link
Collaborator

Merging so I can give it a go.

@TomasTomecek TomasTomecek merged commit c54bae3 into fedora-copr:main Jan 20, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants