-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store payload in Webhook History & make webhook ID clickable to show corresponding payload #3467
base: main
Are you sure you want to change the base?
Conversation
0ffed19
to
f77e9df
Compare
const jsonData = element.getAttribute('data-json'); | ||
if(jsonData === "null") return; | ||
const newTab = window.open(); | ||
newTab.document.write('<pre>' + JSON.stringify(JSON.parse(jsonData), null, 2) + '</pre>'); |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
DOM text
Thank you very much for your work on this! Team: Could someone start a discussion on the Fedora Devel mailing list |
We also discussed that we could make the payloads downloadable only for project admins. Which is already done because the whole Settings > Integrations page requires login. The problem is that we do daily database dumps and allow anyone to download them. So we would have to exclude this table from the dumps. There is a precedent for this, which is for example a table with user API keys for copr-cli. We talked that it would make our life easier if the
So, not very user-friendly. |
If we provide documentation on how to do the boilerplate setup (token?), and the table self-links this documentation, I don't think it is toooo bad. 👍 |
sorry marked it ready for review by mistake. please ignore. |
@jaitjacob hello, how is this PR going? Do you think we could document the way(s) how to "to get the payload"? |
In this PR,
showJson
,Reference,
https://developer.mozilla.org/en-US/docs/Learn/HTML/Howto/Use_data_attributes
Fixed #634