Use the consolidated snapshot API in Unitrace to support Zoomer #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Similar to D48210543. Update the training_hooks to use the Unitrace memory snapshot APIs. This allows us to maintain a singel path for memory snapshot APIs, and also collect important details such as snapshot location for Zoomer. Differential Revision: D48368150 fbshipit-source-id: d71095d2de78ab410b005106ffb6b740ee20716a
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48368150 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D48368150 |
|
@HugeEngine has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was exported from Phabricator. Differential Revision: D48368150 |
HugeEngine
pushed a commit
to HugeEngine/d2go
that referenced
this pull request
Nov 15, 2023
Summary: Similar to D48210543. Update the training_hooks to use the Unitrace memory snapshot APIs. This allows us to maintain a singel path for memory snapshot APIs, and also collect important details such as snapshot location for Zoomer. Pull Request resolved: facebookresearch#613 Reviewed By: frabu6, jackiexu1992 Differential Revision: D48368150 Pulled By: HugeEngine fbshipit-source-id: ed5d819153bdebef4143fa0794855bfc0640ccda
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Similar to D48210543. Update the training_hooks to use the Unitrace memory snapshot APIs. This allows us to maintain a singel path for memory snapshot APIs, and also collect important details such as snapshot location for Zoomer.
Differential Revision: D48368150