Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fb][react-dom] remove render/unmount from ReactDOMRootFB #31972

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kassens
Copy link
Member

@kassens kassens commented Jan 3, 2025

No description provided.

Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 9:36pm

@react-sizebot
Copy link

Comparing: bf883be...c609107

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 512.56 kB 512.56 kB = 91.61 kB 91.61 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 517.34 kB 517.34 kB = 92.46 kB 92.46 kB
facebook-www/ReactDOM-prod.classic.js = 594.36 kB 594.19 kB = 104.68 kB 104.66 kB
facebook-www/ReactDOM-prod.modern.js = 584.62 kB 584.45 kB = 103.14 kB 103.11 kB
test_utils/ReactAllWarnings.js = 63.02 kB 61.58 kB = 15.68 kB 15.38 kB
oss-experimental/react-reconciler/cjs/react-reconciler-reflection.development.js = 6.80 kB 6.15 kB = 1.66 kB 1.60 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler-reflection.development.js = 6.80 kB 6.15 kB = 1.66 kB 1.60 kB
oss-stable/react-reconciler/cjs/react-reconciler-reflection.development.js = 6.80 kB 6.15 kB = 1.66 kB 1.60 kB
oss-experimental/react-reconciler/cjs/react-reconciler-reflection.production.js = 5.69 kB 5.13 kB = 1.53 kB 1.48 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler-reflection.production.js = 5.69 kB 5.13 kB = 1.53 kB 1.48 kB
oss-stable/react-reconciler/cjs/react-reconciler-reflection.production.js = 5.69 kB 5.13 kB = 1.53 kB 1.48 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js = 63.02 kB 61.58 kB = 15.68 kB 15.38 kB
oss-experimental/react-reconciler/cjs/react-reconciler-reflection.development.js = 6.80 kB 6.15 kB = 1.66 kB 1.60 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler-reflection.development.js = 6.80 kB 6.15 kB = 1.66 kB 1.60 kB
oss-stable/react-reconciler/cjs/react-reconciler-reflection.development.js = 6.80 kB 6.15 kB = 1.66 kB 1.60 kB
oss-experimental/react-reconciler/cjs/react-reconciler-reflection.production.js = 5.69 kB 5.13 kB = 1.53 kB 1.48 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler-reflection.production.js = 5.69 kB 5.13 kB = 1.53 kB 1.48 kB
oss-stable/react-reconciler/cjs/react-reconciler-reflection.production.js = 5.69 kB 5.13 kB = 1.53 kB 1.48 kB

Generated by 🚫 dangerJS against 9d80d4c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants