Add isSurfaceRunning / getRunningSurfaces util functions to SurfaceManager #48484
+25
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67814092 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 4, 2025
…nager (facebook#48484) Summary: [Changelog] [Internal] - Add isSurfaceRunning / getRunningSurfaces util functions to SurfaceManager This exposes convience getter methods to data already stored in SurfaceManager Differential Revision: D67814092
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 4, 2025
…nager (facebook#48484) Summary: [Changelog] [Internal] - Add isSurfaceRunning / getRunningSurfaces util functions to SurfaceManager This exposes convience getter methods to data already stored in SurfaceManager Differential Revision: D67814092
christophpurrer
force-pushed
the
export-D67814092
branch
from
ce30db5 to
eb8ab87
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67814092 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 4, 2025
…nager (facebook#48484) Summary: [Changelog] [Internal] - Add isSurfaceRunning / getRunningSurfaces util functions to SurfaceManager This exposes convience getter methods to data already stored in SurfaceManager Differential Revision: D67814092
christophpurrer
force-pushed
the
export-D67814092
branch
from
eb8ab87 to
6cbf8f7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67814092 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 4, 2025
…nager (facebook#48484) Summary: [Changelog] [Internal] - Add isSurfaceRunning / getRunningSurfaces util functions to SurfaceManager This exposes convience getter methods to data already stored in SurfaceManager Differential Revision: D67814092
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 4, 2025
… SurfaceManager (facebook#48484) Summary: [Changelog] [Internal] - Add isSurfaceRunning / getRunningSurfaces util functions to SurfaceManager This exposes convience getter methods to data already stored in SurfaceManager Differential Revision: D67814092
christophpurrer
force-pushed
the
export-D67814092
branch
from
6cbf8f7 to
74a366e
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 4, 2025
…nager (facebook#48484) Summary: [Changelog] [Internal] - Add isSurfaceRunning / getRunningSurfaces util functions to SurfaceManager This exposes convience getter methods to data already stored in SurfaceManager Differential Revision: D67814092
…ok#48483) Summary: [Changelog] [Internal] - Avoid double locking the mutex in SurfaceManager::stopSurface The mutex is already locked in `visit(...`, we can avoid looking the mutex right afterwards Differential Revision: D67817478
…nager (facebook#48484) Summary: [Changelog] [Internal] - Add isSurfaceRunning / getRunningSurfaces util functions to SurfaceManager This exposes convience getter methods to data already stored in SurfaceManager Differential Revision: D67814092
|
This pull request was exported from Phabricator. Differential Revision: D67814092 |
christophpurrer
force-pushed
the
export-D67814092
branch
from
74a366e to
b459320
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 4, 2025
… SurfaceManager (facebook#48484) Summary: [Changelog] [Internal] - Add isSurfaceRunning / getRunningSurfaces util functions to SurfaceManager This exposes convience getter methods to data already stored in SurfaceManager Differential Revision: D67814092
|
This pull request was exported from Phabricator. Differential Revision: D67814092 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 4, 2025
…nager (facebook#48484) Summary: [Changelog] [Internal] - Add isSurfaceRunning / getRunningSurfaces util functions to SurfaceManager This exposes convience getter methods to data already stored in SurfaceManager Differential Revision: D67814092
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
[Changelog] [Internal] - Add isSurfaceRunning / getRunningSurfaces util functions to SurfaceManager
This exposes convience getter methods to data already stored in SurfaceManager
Differential Revision: D67814092