Remove mocks from MBM surrogate tests #3255
Closed
+167
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: * Use of TypeVars: A `TypeVar` indicates that multiple objects (e.g. an argument and a return type) are the same type. Using `TypeVar`s with functions that work with either numpy arrays or torch tensors indicates that either everything is a numpy array or everything is a tensor. Otherwise, Pyre has no idea whether arrays might be randomly turning into tensors and vice versa. * Added more detailed comments on tensor shapes * Used `Sequence` instead of `list` Reviewed By: saitcakmak Differential Revision: D68332888
Summary: * In `test_fit_model_reuse`, `test_fit_multiple_model_configs`, `test_fit_model_selection_metric_to_model_configs_multiple_metrics`, `test_predict`, remove mocks or use them with `wraps`, and use `mock_botorch_optimize` where not already used. In `test_best_in_sample_point`: * Make data and TorchOptConfig work with 2 outcomes, as they previously did not. * Once I did that, the test was failing because there were no points inside the search space, so I added a case where they all are and a case where one is. Reviewed By: saitcakmak Differential Revision: D68333000
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68333000 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Jan 21, 2025
Summary: * In `test_fit_model_reuse`, `test_fit_multiple_model_configs`, `test_fit_model_selection_metric_to_model_configs_multiple_metrics`, `test_predict`, remove mocks or use them with `wraps`, and use `mock_botorch_optimize` where not already used. In `test_best_in_sample_point`: * Make data and TorchOptConfig work with 2 outcomes, as they previously did not. * Once I did that, the test was failing because there were no points inside the search space, so I added a case where they all are and a case where one is. Reviewed By: saitcakmak Differential Revision: D68333000
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3255 +/- ##
=======================================
Coverage 95.87% 95.88%
=======================================
Files 513 513
Lines 51710 51729 +19
=======================================
+ Hits 49579 49598 +19
Misses 2131 2131 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 74149da. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
test_fit_model_reuse,test_fit_multiple_model_configs,test_fit_model_selection_metric_to_model_configs_multiple_metrics,test_predict, remove mocks or use them withwraps, and usemock_botorch_optimizewhere not already used.In
test_best_in_sample_point:Reviewed By: saitcakmak
Differential Revision: D68333000